This revision was automatically updated to reflect the committed changes.
Closed by commit R289:054b4548ce1e: Build the Java side with Gradle, as AAR
instead of JAR (authored by vkrause).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D17986?vs=48881&id=49026#toc
REPOSITORY
R289 KNotifi
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17986
To: vkrause, apol
Cc: apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, b
vkrause added inline comments.
INLINE COMMENTS
> apol wrote in FindGradle.cmake:5
> Sounds like it should be in ECM, no?
Right, that's the obvious final location for this, once it has proven itself as
the right approach here.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabrica
vkrause updated this revision to Diff 48881.
vkrause added a comment.
Move Android specifc stuff into a subdir.
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17986?vs=48727&id=48881
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17
apol added a comment.
Maybe put it in an android subdirectory? having it straight in src feels odd.
Other than that +1
INLINE COMMENTS
> FindGradle.cmake:5
> +#
> +# Provides the ability to build Android AAR libraries using Gradle.
> +#
Sounds like it should be in ECM, no?
REPOSITORY
vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.
REVISION SUMMARY
Most importantly this allows us to use the AndroidX support library, to
properly support a wide range of different And
