D17991: Refactor the way device backends are built and registered

2019-05-11 Thread Pino Toscano
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R245:97d95e3171c3: Refactor the way device backends are built and registered (authored by pino). CHANGED PRIOR TO COMMIT

D17991: Refactor the way device backends are built and registered

2019-04-03 Thread Pino Toscano
pino added a comment. BTW if nobody will comment on this within one month, I will commit it as-is. 4 months without a review will be enough, considering also other reviews for Solid got comments/approvals. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To:

D17991: Refactor the way device backends are built and registered

2019-04-03 Thread Pino Toscano
pino updated this revision to Diff 55373. pino added a comment. Rebase on master. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17991?vs=51892&id=55373 BRANCH cmake-backends-refactor (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D17991: Refactor the way device backends are built and registered

2019-02-16 Thread Pino Toscano
pino added subscribers: FreeBSD, Windows, Android, Frameworks. Herald removed a subscriber: Frameworks. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To: pino Cc: #android, #windows, #freebsd, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17991: Refactor the way device backends are built and registered

2019-02-16 Thread Pino Toscano
pino updated this revision to Diff 51892. pino added a comment. Hopefully rebase on master. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17991?vs=51891&id=51892 BRANCH cmake-backends-refactor (branched from master) REVISION DETAIL https://phabricator.

D17991: Refactor the way device backends are built and registered

2019-02-16 Thread Pino Toscano
pino updated this revision to Diff 51891. pino added a comment. Rebased on master. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17991?vs=48745&id=51891 BRANCH cmake-backends-refactor (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D17991: Refactor the way device backends are built and registered

2019-01-29 Thread Aleix Pol Gonzalez
apol added a comment. Looks good to me. +1 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To: pino Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17991: Refactor the way device backends are built and registered

2019-01-27 Thread Pino Toscano
pino added a comment. ping? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D17991 To: pino Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17991: Refactor the way device backends are built and registered

2019-01-05 Thread Pino Toscano
pino added a comment. This is tested so far only on Linux, where the cmake output for the device backends is: -- The following features have been enabled: * fakehw, Solid device 'fakehw' backend. * udev, Solid device 'udev' backend. * udisks2, Solid device 'udisks2'

D17991: Refactor the way device backends are built and registered

2019-01-05 Thread Pino Toscano
pino created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY Currently, the bits of information of each device backend (e.g. udev, upower, etc) are spread in different files: - the