D17999: ViewConfig: Add option to paste at cursor position by mouse

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e1b5f3177d42: ViewConfig: Add option to paste at cursor position by mouse (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.

D17999: ViewConfig: Add option to paste at cursor position by mouse

dhaumann accepted this revision. REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, bruns, demsking, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#389148 , @cullmann wrote: > "Paste by mouse at cursor position" should be ok, then I will push this, ok? Well, a last close look is nerver bad. REVISION DETAIL https://phabricator.kde.org/D17999 To: l

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar updated this revision to Diff 48999. loh.tar added a comment. Back to "Paste by mouse at cursor position" CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17999?vs=48778&id=48999 REVISION DETAIL https://phabricator.kde.org/D17999 AFFECTED FILES src/dialogs/editconfigwidge

D17999: ViewConfig: Add option to paste at cursor position by mouse

cullmann added a comment. "Paste by mouse at cursor position" should be ok, then I will push this, ok? REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, b

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Sure, can do it. Which one have it to be ? - Paste clipboard contents at cursor location - Paste clipboard contents at cursor position - Paste by mouse at cursor position (This one was liked by Dominik, IIRC) REVISION DETAIL https://phabricator.kde.org/D1799

D17999: ViewConfig: Add option to paste at cursor position by mouse

cullmann added a comment. I can live with the checkbox, too, as the first iteration, but I think you need to change the text in the UI file, atm there is still that "mouse cursor position", should it no be "cursor position"? REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar,

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. To avoid further comments I like to add that I don't like to do the requested change. Please improve it later, if needed. REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frame

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. I agree, it's on the first sight pretty clear. But then can you force this "style" for every bool option. In the above linked pic is this obviously only used for Normal vs Vi-Mode [1] A drawback of that "style" may that you can't say for sure "which is what" in

D17999: ViewConfig: Add option to paste at cursor position by mouse

cullmann added a comment. In D17999#387760 , @ngraham wrote: > Hmm, maybe I misunderstood the feature then, sorry! > > In cases where there are two binary options but both are semi-confusing, or when one option does not necessarily imply its

D17999: ViewConfig: Add option to paste at cursor position by mouse

ngraham added a comment. Hmm, maybe I misunderstood the feature then, sorry! In cases where there are two binary options but both are semi-confusing, or when one option does not necessarily imply its inverse, radio buttons or a combobox are ideal because then you can make both choices ve

D17999: ViewConfig: Add option to paste at cursor position by mouse

dhaumann added a comment. Yes, directed @ngraham :-) REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, bruns, demsking, cullmann, sars

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#387370 , @dhaumann wrote: > Hm, didn't you switch the meaning... I hope you mean @ngraham :-) I just typed overslept what he wrote...yes he has. Before I only kill that "mouse" I like to ask the native

D17999: ViewConfig: Add option to paste at cursor position by mouse

dhaumann added a comment. Hm, didn't you switch the meaning from "Paste by mouse at cursor position" to "Paste clipboard contents at mouse cursor location"? My point is "paste ...at mouse cursor location" is the current behavior, since paste via middle mouse button moves the text cursor posi

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar updated this revision to Diff 48778. loh.tar edited the summary of this revision. loh.tar added a comment. Change checkbox text as suggested CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17999?vs=48764&id=48778 REVISION DETAIL https://phabricator.kde.org/D17999 AFFECTED

D17999: ViewConfig: Add option to paste at cursor position by mouse

ngraham added a comment. I would change the string to "Paste clipboard contents at mouse cursor location". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexte

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set. A look at that bug report may give more hints/ideas REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D179

D17999: ViewConfig: Add option to paste at cursor position by mouse

dhaumann added subscribers: ngraham, dhaumann. dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Good patch, I think this can go in. @ngraham: You as native English speaker, is the wording in the dialog ok? REPOSITORY R39 KTextEd

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this option is the cursor not moved to the mouse position