D18116: Don't show document load trouble twice

2019-02-02 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Just to be sure: We can apply D18117 and don't need to change here anything or? REVISION DETAIL https://phabricator.kde.org/D18116

D18116: Don't show document load trouble twice

2019-01-22 Thread Christoph Cullmann
cullmann added a comment. I would not change that here, I would just ignore it in the application, as said in the other diff. REVISION DETAIL https://phabricator.kde.org/D18116 To: loh.tar, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase,

D18116: Don't show document load trouble twice

2019-01-21 Thread Dominik Haumann
dhaumann added a comment. Just for info: If openingErrorMessage is indeed not set anymore, this is a behavior change, since KTextEditor::Document::openingErrorMessage() is public API. Looking at lxr.kde.org, it seems this is not used (but ->openingError() is used, see

D18116: Don't show document load trouble twice

2019-01-21 Thread loh tar
loh.tar updated this revision to Diff 50027. loh.tar added a comment. - Don't set m_openingErrorMessage in KateBuffer::openFile - m_openingErrorMessage is now nowhere set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18116?vs=49031=50027 REVISION DETAIL

D18116: Don't show document load trouble twice

2019-01-08 Thread loh tar
loh.tar added a comment. I have it only poor tested with our big S file, so no test was made with other trouble causing stuff. This need a patch in Kate, will try to link that KateBuffer::openFile - There is no distingues from 1. "create new file by command line" and 2.

D18116: Don't show document load trouble twice

2019-01-08 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Since there are fancy "in view" messages