D18263: [CopyJob] Provide more descriptive notification header

2019-03-02 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:344 > +const QString destStr = > KStringHandler::csqueeze(m_dest.toDisplayString(QUrl::PreferLocalFile), 100); > +m_description =

D18263: [CopyJob] Provide more descriptive notification header

2019-01-15 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. They emit a generic message. A descriptive message can only generated from within job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18263: [CopyJob] Provide more descriptive notification header

2019-01-15 Thread Kai Uwe Broulik
broulik added a comment. Isn't that done by `emitCopying` et al? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18263 To: chinmoyr, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18263: [CopyJob] Provide more descriptive notification header

2019-01-15 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. chinmoyr added reviewers: dfaure, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. chinmoyr requested review of this revision. REVISION SUMMARY A job can internally set a more descriptive title or a generic title will b