This revision was automatically updated to reflect the committed changes.
Closed by commit R241:8e3b39635cb5: [KUrlNavigatorPlacesSelector] Properly
identify teardown action (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18425?vs=64792&id=66
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18425
To: broulik, #frameworks, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
broulik added a comment.
Ping
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18425
To: broulik, #frameworks, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
broulik updated this revision to Diff 64792.
broulik added a comment.
- Remove pointless `isEmpty` check
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18425?vs=64791&id=64792
REVISION DETAIL
https://phabricator.kde.org/D18425
AFFECTED FILES
src/filewidge
broulik updated this revision to Diff 64791.
broulik edited the test plan for this revision.
broulik added a comment.
- Iterate all actions
- Set the id on the separator as well so we can identify it easily
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18425
broulik planned changes to this revision.
broulik added a comment.
There seems to be one issue that when you open a mounted drive directly, you
get an "Unmount" entry at the top.
Likely because the places are populated after the entry was created.
Perhaps the remove codepath needs to itera
anthonyfieroni added a comment.
+1
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18425
To: broulik, #frameworks, dfaure
Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns
broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Rather than relying on the model count (which broke when we added places
c
