D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#401517 , @dhaumann wrote: > 1. I apply your patch: arc patch D18475 Thanks for the information. And many thanks for your time spent on reviewing. Cheers REPO

D18475: Add AsciiDoc support

This revision was automatically updated to reflect the committed changes. Closed by commit R216:de5fc35624d2: Add AsciiDoc support (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18475?vs=50391&id=50453#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST U

D18475: Add AsciiDoc support

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. 1. I apply your patch: arc patch D18475 2. Since there is a new syntax highlighting file, I do: touch data/syntax-data.qrc.in 3. I switch to the

D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#400238 , @nibags wrote: > Hi!! > Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`.

D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#400989 , @nibags wrote: > If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal).

D18475: Add AsciiDoc support

nibags added a comment. If you are only going to use the "admonition" keywords list for autocompletion, you could add them to the end of the context "section" or "start", keeping the attribute (Normal). I have done this in some highlight files REPOSITORY R216 Syntax Highlighting REVISION

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50391. andreasgr added a comment. Fix diff. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50390&id=50391 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED FILES autotests/input/as

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50390. andreasgr added a comment. - Added test AsciiDoc. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50388&id=50390 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED FILES autot

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50388. andreasgr added a comment. - Drop unused 'admonition' keyword list. - Rename itemData elements to start with capital letters. - Enable escaping in block and section titles. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE htt

D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#400893 , @dhaumann wrote: > Running the katesyntaxhighlighting indexer tells me: > > katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists:

D18475: Add AsciiDoc support

dhaumann added a comment. Running the katesyntaxhighlighting indexer tells me: katehighlightingindexer::KeywordChecker::check: "syntax-highlighting/data/syntax/asciidoc.xml" Unused keyword lists: "admonition" Could you fix this? Usually, keyword completion should be context depend

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50382. andreasgr added a comment. Drop custom colors and backgrounds. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18475?vs=50263&id=50382 REVISION DETAIL https://phabricator.kde.org/D18475 AFFECTED

D18475: Add AsciiDoc support

dhaumann added a comment. With respect to colors: it's more important to be consistent with other highlightings in kate that with AsciiDoctor. Indeed, it would be nice if you can avoid any hard coded color. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/

D18475: Add AsciiDoc support

andreasgr added a comment. In D18475#400238 , @nibags wrote: > Hi!! > Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`.

D18475: Add AsciiDoc support

nibags added a comment. Hi!! Please, also add a test file in: "autotests/input/". To generate the files in "folding", "html" and "reference" use `make test` and `autotests/update-reference-data.sh`. I am not a reviewer, but I want to add some recommendations in relation to the itemDat

D18475: Add AsciiDoc support

andreasgr updated this revision to Diff 50263. andreasgr removed projects: Frameworks, Kate. andreasgr added a comment. Herald added projects: Kate, Frameworks. - Add missing allowed leading characters for links. - Add escaping of attribute usage. - Avoid highlighting of spaces inside table

D18475: Add AsciiDoc support

andreasgr created this revision. andreasgr added a reviewer: Framework: Syntax Highlighting. andreasgr added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. andreasgr requested review of this revision.