D18603: Implement more tags for taglib writer

This revision was automatically updated to reflect the committed changes. Closed by commit R286:926c70460edc: Implement more tags for taglib writer (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=55126=55427 REVISION

D18603: Implement more tags for taglib writer

astippich updated this revision to Diff 55126. astippich added a comment. - rebase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=50705=55126 BRANCH enhance_taglibwriter2 REVISION DETAIL https://phabricator.kde.org/D18603 AFFECTED

D18603: Implement more tags for taglib writer

astippich marked an inline comment as done. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter2 REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,

D18603: Implement more tags for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwriter.cpp:134 > TagLib::MPEG::File file(, > TagLib::ID3v2::FrameFactory::instance(), false); > -auto savedProperties = file.properties(); > -writeGenericProperties(savedProperties, properties); I think you have to

D18603: Implement more tags for taglib writer

astippich updated this revision to Diff 50705. astippich added a comment. - rebase on latest parent revision REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18603?vs=50501=50705 BRANCH enhance_taglibwriter2 REVISION DETAIL

D18603: Implement more tags for taglib writer

astippich added inline comments. INLINE COMMENTS > bruns wrote in taglibwritertest.cpp:276 > You should probably add a warning when `extractorList.size() > 1`, as in this > case the extractor you run would be arbitrary. > > Though, I am currently not aware of cases where one mimetype is

D18603: Implement more tags for taglib writer

bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:276 > +QFAIL("This mime type is not supported by the extractor. Likely a > newer KDE Frameworks version is required."); > +KFileMetaData::Extractor* ex = extractorList.first(); > +

D18603: Implement more tags for taglib writer

astippich added a dependent revision: D18604: Implement support for writing rating information for taglib writer. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc:

D18603: Implement more tags for taglib writer

astippich added a comment. I forgot to add the dependent revision. Thanks for the review, as it's been hard lately to get a reply to anything related to KFileMetaData REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To:

D18603: Implement more tags for taglib writer

astippich added a dependency: D18601: Rewrite taglib writer to use property interface. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D18603: Implement more tags for taglib writer

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH enhance_taglibwriter REVISION DETAIL https://phabricator.kde.org/D18603 To: astippich, bruns, mgallien, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18603: Implement more tags for taglib writer

astippich created this revision. astippich added reviewers: bruns, mgallien. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Implement more tags for writing for the taglib writer