D18822: Fix Windows build [hopefully]

2019-02-07 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D18822 AFFECTED FILES autotests/BackendsManager.h

D18822: Fix Windows build [hopefully]

2019-02-07 Thread Albert Astals Cid
aacid added subscribers: vonreth, kossebau. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid Cc: kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

D18822: Fix Windows build [hopefully]

2019-02-07 Thread Friedrich W. H. Kossebau
kossebau added a comment. Looks fine to me from quick reading, everything done I would have thought of (whatever that is worth :P ) +1 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid Cc: kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bru

D18822: Fix Windows build [hopefully]

2019-02-07 Thread Albert Astals Cid
aacid added a subscriber: albertvaka. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid Cc: albertvaka, kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

D18822: Fix Windows build [hopefully]

2019-02-09 Thread Hannah von Reth
vonreth requested changes to this revision. vonreth added a comment. This revision now requires changes to proceed. Doesn't build yet, we really need pre commit ci Scanning dependencies of target KF5AuthCore_autogen [ 1%] Automatic MOC for target KF5AuthCore [ 1%] Built tar

D18822: Fix Windows build [hopefully]

2019-02-09 Thread Friedrich W. H. Kossebau
kossebau added a comment. Given the autotests reuse the source files from the lib (and thus also using the headers) the export macros confuse windows here. So in autotests/CMakeLists,txt, one needs to extend target_compile_definitions(kauth_tests_static PUBLIC KAUTH_STATIC_DEFINE=1

D18822: Fix Windows build [hopefully]

2019-02-12 Thread Friedrich W. H. Kossebau
kossebau added a comment. Given this seems stuck by missing reviewers, IMHO time to test the fix by try & error on the CI. If no-one would dare to do this, would take over, given I got pulled in and now this unsolved thing steals my attention time ;) REPOSITORY R283 KAuth REVISION DETAIL

D18822: Fix Windows build [hopefully]

2019-02-13 Thread Ben Cooksley
bcooksley added a comment. @kossebau Please go ahead with testing via trial and error in this manner. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18822 To: aacid, vonreth Cc: bcooksley, albertvaka, kossebau, vonreth, kde-frameworks-devel, michaelh, ngraham, bruns

D18822: Fix Windows build [hopefully]

2019-02-13 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R283:c0854de284b7: Fix Windows build [hopefully] (authored by aacid, committed by kossebau). CHANGED PRIOR TO COMMIT ht

D18822: Fix Windows build [hopefully]

2019-02-13 Thread Friedrich W. H. Kossebau
kossebau added a comment. Good news, kauth now passed at least CI again for all platforms tested there (so incl. Windows) :) Your iniail fix was almost complete, @aacid, just missed that last bit for the autotests code, so take pride here :) REPOSITORY R283 KAuth REVISION DETAIL https:/