D18864: FlatBuffers schema syntax highlighting

2019-02-11 Thread Harald Fernengel
This revision was automatically updated to reflect the committed changes. Closed by commit R216:926feb55fa02: FlatBuffers schema syntax highlighting (authored by harald). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18864?vs=51331&id=51398 REVIS

D18864: FlatBuffers schema syntax highlighting

2019-02-10 Thread Dominik Haumann
dhaumann accepted this revision. REPOSITORY R216 Syntax Highlighting BRANCH flatbuffers (branched from master) REVISION DETAIL https://phabricator.kde.org/D18864 To: harald, dhaumann, cullmann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, d

D18864: FlatBuffers schema syntax highlighting

2019-02-10 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. I think that is ok ;=) Thanks for the contribution, and nice to read from you Harald, too ;=) REPOSITORY R216 Syntax Highlighting BRANCH flatbuffers (branched from master) REVISION DETAIL https://phabricator.kde.org/D18864 T

D18864: FlatBuffers schema syntax highlighting

2019-02-10 Thread Harald Fernengel
harald marked 2 inline comments as done. harald added a comment. In D18864#408305 , @dhaumann wrote: > Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file

D18864: FlatBuffers schema syntax highlighting

2019-02-10 Thread Harald Fernengel
harald updated this revision to Diff 51331. harald added a comment. Added test, license and highlighting of attributes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18864?vs=51217&id=51331 BRANCH flatbuffers (branched from master) REVISION

D18864: FlatBuffers schema syntax highlighting

2019-02-08 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file for unit testing? It can be short, is not

D18864: FlatBuffers schema syntax highlighting

2019-02-08 Thread Harald Fernengel
harald created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. harald requested review of this revision. REVISION SUMMARY Support for FlatBuffers schema, for grammar see https://google.github.io/flatbuffers/flatbuffers_gramm