D18891: Avoid leaking a QObject in ExternalExtractor

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko, astippich. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Passing a nullptr as a parent is fine, passing

D18891: Avoid leaking a QObject in ExternalExtractor

dhaumann added a comment. ThT looks reasonable, if ExtractorPlugin even has `QObject * parent = nullptr` I'd even remove nullptr as well. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18891 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: dhau

D18891: Avoid leaking a QObject in ExternalExtractor

bruns added a comment. In D18891#409003 , @dhaumann wrote: > That looks reasonable, if ExtractorPlugin even has `QObject * parent = nullptr` I'd even remove nullptr as well. No, no default value ... REPOSITORY R286 KFileMetaData REVIS

D18891: Avoid leaking a QObject in ExternalExtractor

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH submit REVISION DETAIL https://phabricator.kde.org/D18891 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: dhaumann, kde-frameworks-devel, ashaposhnikov, mi

D18891: Avoid leaking a QObject in ExternalExtractor

This revision was automatically updated to reflect the committed changes. Closed by commit R286:73d5fbbf5fb0: Avoid leaking a QObject in ExternalExtractor (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18891?vs=51298&id=51316 REVISI