D18894: [RFC] General config interface

2019-03-04 Thread loh tar
loh.tar abandoned this revision. loh.tar added a comment. In favor of D19491 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D18894 To: loh.tar, cullmann, dhaumann Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, do

D18894: [RFC] General config interface

2019-03-03 Thread Christoph Cullmann
cullmann added a comment. Hi, sorry that I didn't look earlier at this ;=) I think in principle, that goes into the right direction. For more compile-time safety I would like to have enums. For the internal design: I would use the QVariant types and I would avoid that expli

D18894: [RFC] General config interface

2019-02-12 Thread Christoph Cullmann
cullmann added a comment. First: the current framework for settings suck, I feel guilty. Second: I think a QVariant based approach would be nicer. I should think about how to do that best. Dominik, didn't you have some generic property stuff in your TikzKit? REPOSITORY R39 KTextE

D18894: [RFC] General config interface

2019-02-10 Thread loh tar
loh.tar added a comment. Contrary to my announcement to use an enum as key I chosed the string for maximum simplicity. Yes, this way you notice a typo only at runtime, but in any case you have to know how some stuff has to be written. An enum key offer not only complile time checks but al

D18894: [RFC] General config interface

2019-02-10 Thread Dominik Haumann
dhaumann added a subscriber: mwolff. dhaumann added a comment. This approach spreads they key "Word Wrap Column" across many files. You have to know the key and avoid typos. Currently we have this hard-coded and therefore statically checked by the compiler, which is very good. In grneral

D18894: [RFC] General config interface

2019-02-10 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Remove unneeded bool configIsRunning, add m_ pref