D19324: Add code-oss icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:54a20776ffb4: Add code-oss icon (authored by axionl, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52826=52827 REVISION

D19324: Add code-oss icon

axionl updated this revision to Diff 52826. axionl added a comment. - Setting my username to pass the automated audit. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52786=52826 BRANCH code-oss (branched from master) REVISION DETAIL

D19324: Add code-oss icon

ndavis added a comment. One last thing, you need to use your real name as your Git user name in order for this patch to pass an automated audit. This page explain how to do that if you need a guide: https://help.github.com/en/articles/setting-your-username-in-git REPOSITORY R266

D19324: Add code-oss icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D19324#421552 , @axionl wrote: > This is my first time to contribute plasma/kde project, I feel sorry for my mistakes and thanks for your

D19324: Add code-oss icon

axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

> > > > - Merge branch 'master' into code-oss > > > > # Updating D19324: Add code-oss icon > > # > > # Enter a brief description of the changes included in this update. > > # The first line is used as subject, next lines as comment. >

D19324: Add code-oss icon

> > BTW, you're meant to put the comment for the diff update at the top, but it's not a huge deal. That's why you keep getting this text in all of your update comments: > > - Merge branch 'master' into code-oss > > # Updating D19324: Add code-oss icon

D19324: Add code-oss icon

axionl updated this revision to Diff 52786. axionl added a comment. - Merge branch 'master' into code-oss Remove the invisible rectangle. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52721=52786 BRANCH code-oss (branched from

D19324: Add code-oss icon

deal. That's why you keep getting this text in all of your update comments: - Merge branch 'master' into code-oss # Updating D19324: Add code-oss icon # # Enter a brief description of the changes included in this update. # The first line is used as subject, next lines

D19324: Add code-oss icon

axionl updated this revision to Diff 52719. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line i

D19324: Add code-oss icon

axionl updated this revision to Diff 52721. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line i

D19324: Add code-oss icon

ndavis added a comment. In D19324#420982 , @axionl wrote: > Just I like it as a modern design style and also avoiding some problems for the similarity of official icon, but if you mind that I can remove it. I think that even though the

D19324: Add code-oss icon

axionl added a comment. In D19324#420976 , @ndavis wrote: > I see you've kept the green on the light theme version instead of using the same icon for both versions. Is there a reason for this or do you just prefer it? > > This looks just

D19324: Add code-oss icon

ndavis added a comment. You also need to optimize the SVG. You can do that by using one of the three SVG optimizers on this page: https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow#svg-optimization I should add that to the HIG at some point in the future. REPOSITORY R266

D19324: Add code-oss icon

ndavis added a comment. I see you've kept the green on the light theme version instead of using the same icon for both versions. Is there a reason for this or do you just prefer it? This looks just about ready to land on the master branch, there are just a few more things you need to

D19324: Add code-oss icon

axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

axionl updated this revision to Diff 52696. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line i

D19324: Add code-oss icon

ndavis added a comment. Much better. Now for some questions and suggestions. Why does the icon use green on the top of the logo? The light theme version doesn't look bad, but isn't the official logo all blue? In general, we try to preserve the original branding. Why is the dark

D19324: Add code-oss icon

axionl updated this revision to Diff 52588. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line i

D19324: Add code-oss icon

axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

axionl edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: ndavis, rooty, ngraham, kde-frameworks-devel, michaelh, bruns

D19324: Add code-oss icon

axionl updated this revision to Diff 52587. axionl added a comment. - Merge branch 'master' into code-oss 1. Updating D19324 <https://phabricator.kde.org/D19324>: Add code-oss icon # 2. Enter a brief description of the changes included in this update. 3. The first line i

D19324: Add code-oss icon

axionl added a comment. In D19324#419767 , @ndavis wrote: > In D19324#419766 , @axionl wrote: > > > I use the Gravit Designer (https://designer.io/) to design this icon, not the inkscape, but I

D19324: Add code-oss icon

ndavis added a comment. In D19324#419766 , @axionl wrote: > I use the Gravit Designer (https://designer.io/) to design this icon, not the inkscape, but I think I can redraw it by inkscape. Please do. KDE software is only made with free

D19324: Add code-oss icon

axionl added a comment. In D19324#419751 , @ndavis wrote: > Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and Gwenview it looks like vector graphics. Something is seriously screwed up in this SVG. Did you use Inkscape?

D19324: Add code-oss icon

axionl updated this revision to Diff 52581. axionl added a comment. - Merge branch 'master' into code-oss REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19324?vs=52571=52581 BRANCH code-oss (branched from master) REVISION DETAIL

D19324: Add code-oss icon

ndavis added a comment. Weird. In Inkscape, the logo looks like raster graphics, but in Dolphin and Gwenview it looks like vector graphics. Something is seriously screwed up in this SVG. Did you use Inkscape? Can you explain what process you used to make this icon? F6636063:

D19324: Add code-oss icon

axionl added a comment. In D19324#419702 , @rooty wrote: > There are commands/aliases here for how to take quick screenshots https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow > > I ran montage-breeze and I got F6635927: new.png

D19324: Add code-oss icon

rooty added a comment. There are quick commands/aliases here for how to take quick screenshots https://invent.kde.org/ndavis/hig-kde-org/wikis/Icon-Workflow I ran it and I got F6635927: new.png which looks really nice. However, is there some

D19324: Add code-oss icon

ngraham added a comment. > `code-oss-dark.svg` Is this the correct name? I assume the app itself isn't named "code-oss-dark", right? Also screenshots are appreciated, as is filling in the test plan. :) https://community.kde.org/Infrastructure/Phabricator#Include_some_screenshots

D19324: Add code-oss icon

rooty added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19324 To: axionl, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19324: Add code-oss icon

axionl created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. axionl requested review of this revision. REVISION SUMMARY Add the code-oss icons follow the breeze and breeze-dark style REPOSITORY R266 Breeze Icons BRANCH code-oss