This revision was automatically updated to reflect the committed changes.
Closed by commit R237:38b51667b5ba: [Kconfig] Compile without foreach (authored
by mlaurent).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19326?vs=52808=53040
REVISION DETAIL
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19326
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent edited the test plan for this revision.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D19326
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent updated this revision to Diff 52808.
mlaurent added a comment.
Fixed code as requested by David
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19326?vs=52579=52808
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Did you check that unittests still pass? (please mention this in the "Test
Plan:" field of the commit when using arc diff)
INLINE COMMENTS
> ksharedconfig.cpp:93
>
> -
mlaurent retitled this revision from "Compile without foreach" to "[Kconfig]
Compile without foreach".
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D19326
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns