D19338: New location for KNSRC files

asturmlechner added a comment. In D19338#676682 , @kossebau wrote: > In D19338#676680 , @asturmlechner wrote: > > > Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs?

D19338: New location for KNSRC files

kossebau added a comment. In D19338#676680 , @asturmlechner wrote: > Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs? On the other hand it makes sense that module-specific variables are provided by the

D19338: New location for KNSRC files

asturmlechner added a comment. Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: asturmlechner, kossebau, kde-frameworks-devel,

D19338: New location for KNSRC files

kossebau added inline comments. INLINE COMMENTS > README.md:60 > +where KNewStuffCore expects it to be found. Do this by using the CMake > variable > +KDE_INSTALL_KNSRCDIR as provided by the KNewStuffCore module. You can also > handle this > +yourself, which means you will need to feed

D19338: New location for KNSRC files

This revision was automatically updated to reflect the committed changes. Closed by commit R304:be0412024a46: New location for KNSRC files (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=53117=53869 REVISION DETAIL

D19338: New location for KNSRC files

ngraham accepted this revision. ngraham added a comment. Works great, thanks. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19338: New location for KNSRC files

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19338: New location for KNSRC files

leinir added a comment. Quick ping, be good to get this in sometime before it becomes late again... :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot,

D19338: New location for KNSRC files

leinir updated this revision to Diff 53117. leinir added a comment. Since 5.57, not 5.56 REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19338?vs=52607=53117 REVISION DETAIL https://phabricator.kde.org/D19338 AFFECTED FILES

D19338: New location for KNSRC files

leinir added a comment. In D19338#420303 , @apol wrote: > +1 cool stuff! > > this opens the possibility for files being both in /usr and /etc, can you make sure hell doesn't break loose when that happens? > > Was these files look up was

D19338: New location for KNSRC files

apol added a comment. +1 cool stuff! this opens the possibility for files being both in /usr and /etc, can you make sure hell doesn't break loose when that happens? Was these files look up was delegated entirely to KConfig? REPOSITORY R304 KNewStuff REVISION DETAIL

D19338: New location for KNSRC files

leinir added a dependent revision: D19340: Search new knsrc locations. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19338 To: leinir, #knewstuff, apol, ngraham, fvogt Cc: kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, ngraham, bruns

D19338: New location for KNSRC files

leinir created this revision. leinir added reviewers: KNewStuff, apol, ngraham, fvogt. leinir added a project: KNewStuff. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This introduces a cmake