D19407: ModeBase::goToPos: Ensure jump target is valid

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. In any case, I think it is OK to make this function save for invalid cursors. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar,

D19407: ModeBase::goToPos: Ensure jump target is valid

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a272e86f07e7: ModeBase::goToPos: Ensure jump target is valid (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar added a comment. Ah, `r.toEditorRange().isValid()` is the trick, yes, would work. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham,

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar added a comment. > Hm, who is passing an invalid range here? Does it matter? Can't remember. Want to see the bt? > Would it be the same to check r.isValid()? No. No such function :p It's a vimode range (?) REPOSITORY R39 KTextEditor REVISION DETAIL

D19407: ModeBase::goToPos: Ensure jump target is valid

dhaumann added a comment. It's FIXED-IN: 5.56... Hm, who is passing an invalid range here? Would it be the same to check r.isValid()? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel,

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar added a comment. - Is "Fixed in" the right term and number? - I noticed that the cursor jumps one line where I would expect not to move, but I don't use vi-mode REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19407 To: loh.tar, #ktexteditor Cc:

D19407: ModeBase::goToPos: Ensure jump target is valid

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY BUG:377200 Fixed in: 5.56 REPOSITORY R39 KTextEditor