This revision was automatically updated to reflect the committed changes.
Closed by commit R304:f7fbcc13f518: [knewstuff] Remove qt5.13 deprecated method
(authored by mlaurent).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19437?vs=53049&id=53053
REVISION
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R304 KNewStuff
BRANCH
remove_deprecated_qt5.13 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19437
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent updated this revision to Diff 53049.
mlaurent added a comment.
Use exitstatus
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19437?vs=52879&id=53049
BRANCH
remove_deprecated_qt5.13 (branched from master)
REVISION DETAIL
https://phabricator.
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> installation.cpp:575
> +connect(ret, static_cast QProcess::ExitStatus)>(&QProcess::finished), this, [this, command](int
> exitcode){
> if (exitco
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
remove deprecated method
TEST PLAN
autotest ok
REPOSITORY
R304 KNewStuff
BRA
