D19438: Add syntax definition for Elm language to syntax-highlighting

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19438 To: bonghyunkim, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns,

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags updated this revision to Diff 55583. nibags added a comment. - Ok! Adding autotest references REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19438?vs=55475=55583 BRANCH arcpatch-D19438 REVISION DETAIL

D19438: Add syntax definition for Elm language to syntax-highlighting

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. It's also ok to generate the reference data om first commit. Often highlighting contributors do not have a compiling KSyntaxHighlighting git around, so this is a significant hurdle.

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19438 To: bonghyunkim, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel,

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags added a comment. - Running `make test`, after adding a new file to `autotests/input`, will throw an error in "testhighlighter_test", "htmlhighlighter_test" and "folding_test", since references haven't been updated. It's normal to show you that error. - You have to execute the

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim updated this revision to Diff 55475. bonghyunkim added a comment. It's been about three weeks since I've uploaded last diff but haven't received any response since then. I've made another diff against the most recent commit of KDE/syntax-highlighting

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim updated this revision to Diff 53736. bonghyunkim added a comment. Sorry that I forgot to update the actual diff file - this should compile now! REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19438?vs=53180=53736 REVISION DETAIL

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags added a comment. It isn't possible to compile, because the `elm.xml` file has multiple issues :( The script "data/schema/validatehl.sh" serves to verify the XML files: cd syntax-highlighting/data/schema/ ./validatehl.sh ../syntax/elm.xml Output:

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim planned changes to this revision. bonghyunkim added a comment. I finally got some time to install various dependencies to set up the tests and run them, but three tests keep failing. They are: folding_test, testhighlighter_test, htmlhighlighter_test. The error message is

D19438: Add syntax definition for Elm language to syntax-highlighting

nibags added a comment. Use: `cmake ./ && make` to compile REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19438 To: bonghyunkim Cc: nibags, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim updated this revision to Diff 53180. bonghyunkim edited the summary of this revision. bonghyunkim added a comment. I created 'highlight.elm' in autotests/input/ folder, as per guide on https://github.com/KDE/syntax-highlighting, but couldn't follow the instruction. I tried

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim planned changes to this revision. bonghyunkim added a comment. In D19438#422676 , @dhaumann wrote: > Could you elaborate what Elm is used for? > Also, could you please provide a small test file (also MIT licensed) that we can use

D19438: Add syntax definition for Elm language to syntax-highlighting

dhaumann added a comment. Could you elaborate what Elm is used for? Also, could you please provide a small test file (also MIT licensed) that we can use for unit testing? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19438 To: bonghyunkim Cc:

D19438: Add syntax definition for Elm language to syntax-highlighting

bonghyunkim created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. bonghyunkim requested review of this revision. REVISION SUMMARY This commit adds syntax definition for Elm language to syntax-highlighting. REPOSITORY