habacker created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.
REVISION SUMMARY
This is required to share printer settings inside an application.
BUG:405011
TEST PLAN
compile on linux
REPOS
tbaumgart added inline comments.
INLINE COMMENTS
> khtmlview.cpp:3134
> +
> +void KHTMLView::print(QPrinter *_printer, bool quick)
> +{
Why don't you pass a reference to the QPrinter object here?
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D19504
To: habacker
Cc: tba
habacker marked an inline comment as done.
habacker added inline comments.
INLINE COMMENTS
> tbaumgart wrote in khtmlview.cpp:3134
> Why don't you pass a reference to the QPrinter object here?
Because api dealing with QPrinter always use a pointer.
void QWebView::print(QPrinter *)
void QPrintP
aacid added a comment.
The code is fine, the bigger question here is if we want new features in
khtml that is part of the "portingAids" part of frameworks.
INLINE COMMENTS
> khtmlview.h:207
> + * @param quick if true, fully automated printing, without print dialog
> + */
> +void
habacker updated this revision to Diff 53327.
habacker marked an inline comment as done.
habacker added a comment.
- added @since tag
The patch was added to build the stable version of KMyMoney
for Windows to fix an issue not been able to have common
printer settings. Since KHTML is th
habacker marked 2 inline comments as done.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D19504
To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, michaelh, ngraham, bruns
habacker added a comment.
ping ?
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D19504
To: habacker
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
habacker updated this revision to Diff 67894.
habacker added a comment.
- Another attempt after 9 minor releases have elapsed.
REPOSITORY
R313 KHtml
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19504?vs=53327&id=67894
BRANCH
master
REVISION DETAIL
https://phabricator.kde.o
ahmadsamir added reviewers: dfaure, vkrause.
REPOSITORY
R313 KHtml
REVISION DETAIL
https://phabricator.kde.org/D19504
To: habacker, dfaure, vkrause
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R313 KHtml
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19504
To: habacker, dfaure, vkrause
Cc: aacid, tbaumgart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,
bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R313:2d8cba050729: Extend KHtmlView::print() to use a
predefined QPrinter instance (authored by habacker).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19504?vs=67894&id=68479#toc
REPOSITORY
R3
11 matches
Mail list logo