This revision was automatically updated to reflect the committed changes.
Closed by commit R278:abcf323ab6f3: Send blur/background contrast in device
pixels (authored by davidedmundson).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19544?vs=53210&id=53
zzag accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19544
To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added inline comments.
INLINE COMMENTS
> zzag wrote in kwindoweffects.cpp:266
> should we floor or round?
Our best option is to match QHighDpi::toNativePixels(QRect)
Which seems to floor
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D19544
To: d
zzag added inline comments.
INLINE COMMENTS
> kwindoweffects.cpp:266
> +auto dpr = qApp->devicePixelRatio();
> +data << r.x() * dpr << r.y() * dpr << r.width() * dpr <<
> r.height() * dpr;
> }
should we floor or round?
REPOSITORY
R278 KWindowSystem
REVISION
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
A Qt app using Qt scaling will only know the position of windows an
