D19771: Use placeholder instead of label

ognarb created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. ognarb requested review of this revision. REVISION SUMMARY See https://hig.kde.org/style/writing/placeholder.html Also change Find -> Search in Search and rep

D19771: Use placeholder instead of label

ognarb edited the summary of this revision. ognarb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19771: Use placeholder instead of label

ognarb added a reviewer: VDG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

ognarb updated this revision to Diff 53922. ognarb added a comment. Use proper Unicode ellipsis REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19771?vs=53919&id=53922 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19771 AFFECTED FILES

D19771: Use placeholder instead of label

ognarb planned changes to this revision. ognarb added a comment. Look likes I misread a part of the HIG: Since the placeholder won’t be visible anymore as soon as the user types, you should only use it on standalone input elements, not in groups of input elements such as forms. So the ch

D19771: Use placeholder instead of label

ognarb added a task: T10258: Use correct search bars and use ellipsis whenever needed to follow the KDE HIG. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham

D19771: Use placeholder instead of label

loh.tar added subscribers: ngraham, loh.tar. loh.tar added a comment. > So the change in Search and replace need to be reverted. That should @ngraham decide. See also https://phabricator.kde.org/T10258#178907 I would badly suggest to use in both cases the same term, "Find" or "Search

D19771: Use placeholder instead of label

ngraham added a comment. "Find" and "search" are different things. Broadly: - "Find" is limited to items in the current view only, and usually pertains to text. - "Search" is anything broader than that. So for this, "Find" is the appropriate term. REPOSITORY R39 KTextEditor REV

D19771: Use placeholder instead of label

cfeck added a comment. In D19771#431674 , @ngraham wrote: > - "Find" is limited to items in the current view only, and usually pertains to text. I prefer the term "Filter" for this. If there is no filter, you see everything, if there is

D19771: Use placeholder instead of label

ngraham added a comment. That's different. "Filter" actually hides non-matched entries. "Find" highlights them while keeping the context and surrounding content. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cfeck, loh.t

D19771: Use placeholder instead of label

loh.tar added a comment. For me is your distinction between Find/Search not very intuitive. But OK, in terms of HIG may that somehow a wanted subtlety. Filter on the other hand is something else, yes, and here not fitting. So "Find..." in both cases. Not answered are the questions about

D19771: Use placeholder instead of label

ngraham added a comment. In D19771#431727 , @loh.tar wrote: > For me is your distinction between Find/Search not very intuitive. But OK, in terms of HIG may that somehow a wanted subtlety. Filter on the other hand is something else, yes, and her

D19771: Use placeholder instead of label

ognarb added a comment. > I'm not aware of why we tend to use three dots instead of the real ellipsis character. Possibly because that character can be challenging to type. Best to follow the existing convention, I think. The advantage of using the unicode ellipsis character, is that thi

D19771: Use placeholder instead of label

ngraham added a comment. Can you bring this up in the VDG channel? If we're going to use the correct character, we should do it everywhere. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cfeck, loh.tar, ngraham, kwrite-de

D19771: Use placeholder instead of label

loh.tar added a comment. In D19771#432157 , @ngraham wrote: > In D19771#431727 , @loh.tar wrote: > > > Not answered are the questions about the removed label > > > The idea is that we don't nee

D19771: Use placeholder instead of label

cullmann added a comment. Hi, if we do that: Could we then remove the "Mode:", too and move that into the combobox? Perhaps like "Plain text search", "Whole words search", ... Otherwise the search&replace doesn't save space and it looks "strange". REPOSITORY R39 KTextEditor REVISION DE

D19771: Use placeholder instead of label

cullmann added a comment. Hi, any more feedback on this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson, michaelh, bruns, demsking, sars, dhaum

D19771: Use placeholder instead of label

ngraham added a comment. In D19771#440886 , @cullmann wrote: > Hi, if we do that: Could we then remove the "Mode:", too and move that into the combobox? > Perhaps like "Plain text search", "Whole words search", ... > Otherwise the search&re

D19771: Use placeholder instead of label

loh.tar added a comment. > Hi, any more feedback on this? When in power mode, and the fields are filled, it is not clear what which field is. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: cullmann, cfeck, loh.tar, n

D19771: Use placeholder instead of label

dhaumann added a comment. In D19771#468881 , @loh.tar wrote: > > Hi, any more feedback on this? > > When in power mode, and the fields are filled, it is not clear what which field is. I think this is a valid concern... REPOSITORY R

D19771: Use placeholder instead of label

ognarb added a comment. Hi, I try to find time to look into it this weekend ;). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, domson, micha

D19771: Use placeholder instead of label

ngraham added a comment. Hmm, now that you mention it, I agree. Maybe we can use placeholder text only for the quick find feature, but use labels for the advanced find-and-replace version? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #kt

D19771: Use placeholder instead of label

cullmann added a comment. I think then it is a bit inconsistent. Would it really be that confusing, given until you write your find/replace stuff inside, you have the labels? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg C

D19771: Use placeholder instead of label

ognarb abandoned this revision. ognarb added a comment. I don't have time and the motivation for this revision anymore. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19771 To: ognarb, #ktexteditor, #vdg Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-dev