D20005: WIP: Find Qt5Widgets, required for Qt5::uic

aacid added a comment. In D20005#437053 , @cgiboudeaux wrote: > In D20005#437052 , @aacid wrote: > > > > Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets. > > > >

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

cgiboudeaux added a comment. In D20005#437052 , @aacid wrote: > > Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets. > > Does it? it doesn't here, or you mean "requires Qt5Widgets" because it tries to use Qt5::u

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

aacid added a comment. But does the code *really* need qwidget? I In D20005#437029 , @cgiboudeaux wrote: > In D20005#436993 , @aacid wrote: > > > That not ideal, ki18n should be usable for proje

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

cgiboudeaux added a comment. In D20005#437029 , @cgiboudeaux wrote: > In D20005#436993 , @aacid wrote: > > > That not ideal, ki18n should be usable for projects that don't use widgets too. > > >

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

cgiboudeaux added a comment. In D20005#436993 , @aacid wrote: > That not ideal, ki18n should be usable for projects that don't use widgets too. > > I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on wi

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

aacid added a comment. That not ideal, ki18n should be usable for projects that don't use widgets too. I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there? REPOSITORY R249 KI18n REVISION DETAIL

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

aspotashev added a comment. I'm not sure about this because 1. Not a find_package() guru 2. We may need to add Qt5Widgets as a new dependency of ki18n. For now ki18n won't pull qtwidgets, and your projects may fail compiling which is not very developer-friendly. REPOSITORY R249 KI18

D20005: WIP: Find Qt5Widgets, required for Qt5::uic

aspotashev created this revision. aspotashev added a reviewer: Frameworks. aspotashev added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aspotashev requested review of this revision. REVISION SUMMARY If I have find_package(KF5I18n ${KF5_MIN_VERSION} CONFIG REQUI