D20145: Fix RGBHandler::canRead

2019-03-31 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R287:9fc6967f4fe5: Fix RGBHandler::canRead (authored by aacid). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20145?vs=55141=55144 REVISION DETAIL

D20145: Fix RGBHandler::canRead

2019-03-31 Thread Albert Astals Cid
aacid added a comment. In D20145#441079 , @apol wrote: > Makes sense, maybe it would make sense to include a test case? if such a thing exists... We already have tests cases, it just does not use canRead, only read. I need this fixed so

D20145: Fix RGBHandler::canRead

2019-03-31 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. Makes sense, maybe it would make sense to include a test case? if such a thing exists... REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20145 To: aacid, svuorela, apol Cc: apol, svuorela,

D20145: Fix RGBHandler::canRead

2019-03-31 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. I'm not sure why it as such is needed, but it isn't wrong. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D20145 To: aacid, svuorela

D20145: Fix RGBHandler::canRead

2019-03-31 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY As one can see in SGIImage::readImage the accepted images are _stream >> u16; if (u16 != 0x01da) {