D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R266:47af5254b039: Add "notifications" and "notifications-disabled" icons (authored by GB_2). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55420&id=55451

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. Those curves are perfect 👌 REPOSITORY R266 Breeze Icons BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg, ngraham, ndavis C

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much nicer! This is a winner IMO. REPOSITORY R266 Breeze Icons BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DETAIL https://phabricator.

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: bruns, ndavis, abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-04 Thread Björn Feber
GB_2 updated this revision to Diff 55420. GB_2 added a comment. Remake icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55347&id=55420 BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DETAIL h

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Noah Davis
ndavis added a comment. In D20226#442934 , @bruns wrote: > Diagonal or round shapes are **not** required to be pixel grid aligned. Actually, it is not even possible, as there is **always** some antialiasing. It even helps to make round shapes a

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Stefan Brüns
bruns added a comment. In D20226#442902 , @ndavis wrote: > The proportions aren't quite right. > > F6749114: Screenshot_20190403_112343.png > > This is one way to make a perfectly smooth bell. Subtra

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Noah Davis
ndavis added a comment. In D20226#442906 , @GB_2 wrote: > In D20226#442882 , @ngraham wrote: > > > Also, could we create a 22x22 version too? > > > How can you efficiently do that without havin

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 added a comment. In D20226#442882 , @ngraham wrote: > Also, could we create a 22x22 version too? How can you efficiently do that without having to realign everything to the new grid manually? REPOSITORY R266 Breeze Icons REVISION

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Noah Davis
ndavis added a comment. The proportions aren't quite right. F6749114: Screenshot_20190403_112343.png This is one way to make a perfectly smooth bell. Subtract the red shapes from the black shapes. F6749117: Screenshot_20190403_112550.png

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Nathaniel Graham
ngraham added a comment. In D20226#442844 , @GB_2 wrote: > In D20226#442841 , @ngraham wrote: > > > +1 in general. However the fact that this black version doesn't match the outline/dimensions of th

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Andres Betts
abetts added a comment. In D20226#442854 , @GB_2 wrote: > Move bell's pendulum Love it! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-framework

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20226 To: GB_2, #plasma, #vdg Cc: abetts, ngraham, #vdg, kde-frameworks-devel, #plasma, michaelh, bruns

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 updated this revision to Diff 55347. GB_2 added a comment. Move bell's pendulum REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20226?vs=55339&id=55347 BRANCH add-notifications-and-notifications-disabled-icons (branched from master) REVISION DE

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Andres Betts
abetts added a comment. The line that goes across almost completely removes the bell's pendulum to the right. Maybe move the pendulum closer to the center so that even when there is that red strike line, the user can still make out that it is a notification bell REPOSITORY R266 Breeze Ico

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 added a comment. In D20226#442841 , @ngraham wrote: > +1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (`preferences-desktop-notification-bell`) is triggering my OCD. :) Do

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Nathaniel Graham
ngraham added a comment. +1 in general. However the fact that this black version doesn't match the outline/dimensions of the colored version (`preferences-desktop-notification-bell`) is triggering my OCD. :) Do you think you could match the dimensions of that icon? REPOSITORY R266 Breeze

D20226: Add "notifications" and "notifications-disabled" icons

2019-04-03 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406121 Needed for the upcoming do not disturb mode and overhauled notifcations. F6