This revision was automatically updated to reflect the committed changes.
Closed by commit R286:a51e96979b4e: Fix extracting of some properties to match
what was written (authored by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
astippich added a comment.
thanks
REPOSITORY
R286 KFileMetaData
BRANCH
arcpatch-D20526
REVISION DETAIL
https://phabricator.kde.org/D20526
To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,
ashaposhnikov, michaelh, astippich, spoorun,
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
arcpatch-D20526
REVISION DETAIL
https://phabricator.kde.org/D20526
To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,
astippich added a comment.
friendly ping, I would like to get this into 5.60
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20526
To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,
ashaposhnikov, michaelh,
astippich marked 2 inline comments as done.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20526
To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
astippich added inline comments.
INLINE COMMENTS
> bruns wrote in taglibextractor.cpp:356
> is this always just one value, or a list as well?
as far as I know, asf only allows single entry tags, so just a single value
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
astippich updated this revision to Diff 60842.
astippich marked an inline comment as done.
astippich added a comment.
- add trimmed(), adjust test
- fileExtension
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20526?vs=60334=60842
BRANCH
bruns added inline comments.
INLINE COMMENTS
> taglibwritertest.cpp:556
> +
> +data.add(Property::Artist, QStringLiteral("Artist1 feat Artist2"));
> +data.add(Property::AlbumArtist, QStringLiteral("Artist1 feat. Artist2"));
const map properties = { {Artist, "Artist", ...};
for
astippich edited the summary of this revision.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D20526
To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,
ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,
astippich retitled this revision from "fix extracting of some properties to
match what was writen" to "Fix extracting of some properties to match what was
written".
astippich edited the summary of this revision.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
10 matches
Mail list logo