D20766: Use appropriate background color for text previews

meven added a comment. I have opened https://phabricator.kde.org/D25323 to fix the missing highlighting in kio-extras. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: dhaumann, cullmann, vkrause, cfeck, meven, broulik, kde-frameworks-devel,

D20766: Use appropriate background color for text previews

meven added a comment. I believe the issue currently is that for text files or files without associated definition we end up with an invalid definition that prevents SyntaxHighlighter::setDefinition to call rehighlight(). QTextDocument uses then whatever it get from the theme I guess.

D20766: Use appropriate background color for text previews

kossebau added a comment. In D20766#488044 , @meven wrote: > For context : > F6943088: Screenshot_20190629_110927.png > > Given D21295 , can we move forward here

D20766: Use appropriate background color for text previews

meven added a comment. For context : F6943088: Screenshot_20190629_110927.png Given D21295 , can we move forward here ? REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc:

D20766: Use appropriate background color for text previews

cullmann added a comment. I actually think the theme should contain all colors hard-coded and KTextEditor should properly use that instead of currently the mix of hardcoded/defaults. The only automatism should be (in my eyes) to switch between a light/dark variant automatic depending on

D20766: Use appropriate background color for text previews

kossebau added a comment. I am even more confused that switching back to "Breeze" from "Breeze Dark", I can still reproduce things when just switching to dark color themes only. So possibly that is enough, and I was before potentially fooled by some running processes, despite making sure no

D20766: Use appropriate background color for text previews

vkrause added subscribers: cullmann, dhaumann. vkrause added a comment. In D20766#454891 , @kossebau wrote: > So, switching also the Plasma Theme to "Breeze Dark", I started to be able to reproduce: seems that the default text color is

D20766: Use appropriate background color for text previews

eshalygin added a comment. I would welcome the same palette in the file preview as the one I see in ktexteditor when open the file REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: vkrause, cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde,

D20766: Use appropriate background color for text previews

cfeck requested changes to this revision. cfeck added a comment. Before we can support both dark and light themes we need to investigate the KSyntaxHighlighting issue found by Friedrich. Later we could request a light or dark theme depending on the lightness of the QPalette entry, but I

D20766: Use appropriate background color for text previews

kossebau added a comment. So, switching also the Plasma Theme to "Breeze Dark", I started to be able to reproduce: seems that the default text color is influenced by that. Which seems a side-effect not to be expected. And this patch here just a work-around for the symptom. We ask

D20766: Use appropriate background color for text previews

kossebau requested changes to this revision. kossebau added a subscriber: vkrause. kossebau added a comment. This revision now requires changes to proceed. For one, I cannot reproduce the bug. With all the dark UI color themes I tested, I always had proper contrasted dark text colors in the

D20766: Use appropriate background color for text previews

kossebau added a comment. BTW, just a note while testing: while the thumbnails curently are not cached but always rerendered on demand (due to flag in metadata), there currently is no update mechanism to update the thumbnails already shown e.g. in Dolphin when the UI color theme changes.

D20766: Use appropriate background color for text previews

ngraham edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp,

D20766: Use appropriate background color for text previews

kossebau added a reviewer: cfeck. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau, cfeck Cc: cfeck, meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

kossebau added a subscriber: cfeck. kossebau added a comment. Thanks for the patch. Hm, somehow I remember from my testing for D19432 that highlighting color did not take active UI color theme into account, has that changed meanwhile? In any case,

D20766: Use appropriate background color for text previews

eshalygin marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau Cc: meven, broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D20766: Use appropriate background color for text previews

meven added inline comments. INLINE COMMENTS > textcreator.cpp:7 Too many lines removed here, it should not compile anymore. Just a small editing mistake I guess. REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau Cc: meven, broulik, kde-frameworks-devel, kfm-devel,

D20766: Use appropriate background color for text previews

eshalygin updated this revision to Diff 56806. eshalygin added a comment. Replace KColorScheme with QPalette CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20766?vs=56805=56806 REVISION DETAIL https://phabricator.kde.org/D20766 AFFECTED FILES thumbnail/textcreator.cpp To:

D20766: Use appropriate background color for text previews

broulik added a reviewer: kossebau. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D20766 To: eshalygin, kossebau Cc: broulik, kde-frameworks-devel, kfm-devel, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns,

D20766: Use appropriate background color for text previews

broulik added inline comments. INLINE COMMENTS > textcreator.cpp:140 > > -QColor bgColor = QColor ( 245, 245, 245 ); // light-grey > background > -m_pixmap.fill( bgColor ); > +m_pixmap.fill( > KColorScheme(QPalette::Active).background().color() ); >

D20766: Use appropriate background color for text previews

eshalygin created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. eshalygin requested review of this revision. REVISION SUMMARY Text previews are unreadable (in fact look empty) with dark colour schemes because of the