D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. ping @dfaure REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham, #frameworks Cc: dfaure, elvisangelaccio, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#492751 , @dfaure wrote: > Strange, I'm pretty sure I was able to reproduce it locally before I wrote my comment here. But now I can't anymore. OK, to be further investigated when either of us have time.

D20838: Allow to drop one file or one folder on KDirOperator

dfaure added a comment. Strange, I'm pretty sure I was able to reproduce it locally before I wrote my comment here. But now I can't anymore. OK, to be further investigated when either of us have time. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven,

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#491992 , @dfaure wrote: > The test fails in CI, please check. > >

D20838: Allow to drop one file or one folder on KDirOperator

dfaure added a comment. The test fails in CI, please check. https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/139/testReport/junit/projectroot/autotests/kiofilewidgets_kfilewidgettest/

D20838: Allow to drop one file or one folder on KDirOperator

This revision was automatically updated to reflect the committed changes. meven marked an inline comment as done. Closed by commit R241:25eb17ffa666: Allow to drop one file or one folder on KDirOperator (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20838: Allow to drop one file or one folder on KDirOperator

ngraham accepted this revision. ngraham added a comment. I think this can land. REPOSITORY R241 KIO BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham, #frameworks Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 58000. meven added a comment. Review, removed a dead variable in test, use QRegularExpression REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57707=58000 BRANCH arcpatch-D20838 REVISION DETAIL

D20838: Allow to drop one file or one folder on KDirOperator

meven marked 8 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham, #frameworks Cc: elvisangelaccio, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

elvisangelaccio added inline comments. INLINE COMMENTS > kfilewidgettest.cpp:38 > +#include > +#include > + Unused? > kfilewidgettest.cpp:407-413 > +QDir f(tempDir.filePath(dir)); > + > +KFileWidget fw(QUrl::fromLocalFile(tempDir.path())); > +

D20838: Allow to drop one file or one folder on KDirOperator

meven added a reviewer: Frameworks. REPOSITORY R241 KIO BRANCH arcpatch-D20838_1 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham, #frameworks Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. Given that nobody else from #frameworks has offered any review comments, I say let's get it in early in this Frameworks cycle (i.e. now-ish) so we have almost a month of testing before release. REPOSITORY R241 KIO

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. @ngraham Should I wait for some more review/testing, or LGTM means let's get this merge ASAP ? REPOSITORY R241 KIO BRANCH arcpatch-D20838_1 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham,

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57707. meven added a comment. update since comment kio version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57636=57707 BRANCH arcpatch-D20838_1 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED

D20838: Allow to drop one file or one folder on KDirOperator

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! INLINE COMMENTS > meven wrote in kdiroperator.cpp:418 > Any idea where I should add this information ? > An example would suffice. You already did, in the inline function

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57636. meven edited the test plan for this revision. meven added a comment. Fix drag^Ciltering, add mime filtering to the drag filtering REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57625=57636 BRANCH

D20838: Allow to drop one file or one folder on KDirOperator

meven planned changes to this revision. meven added a comment. An eventFilter must return true when the event has been processed and prevent further event handling. This prevent the drag filtering to not work (multiple files for instance). The code does not do that currently, I am on it.

D20838: Allow to drop one file or one folder on KDirOperator

meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57625. meven added a comment. review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57599=57625 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven marked 5 inline comments as done. meven added inline comments. INLINE COMMENTS > ngraham wrote in kdiroperator.cpp:418 > Yep, I'd say so now. Any idea where I should add this information ? An example would suffice. REPOSITORY R241 KIO REVISION DETAIL

D20838: Allow to drop one file or one folder on KDirOperator

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Still works great, and I have just a few code change requests. Then let's aim to land this early in the 5.59 cycle so it gets lots of testing. INLINE COMMENTS > meven wrote in

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57599. meven added a comment. oops REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57597=57599 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57597. meven added a comment. Clean up test code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57589=57597 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57589. meven added a comment. Clean up and fix test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57442=57589 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57442. meven added a comment. Grab the focus so that the currentItem becomes the kfilewidget selected item, otherwise the user needs to give the kdiroperator the focus first REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57441. meven added a comment. Fix an issue where the closuser would be called for each finished event once set REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57124=57441 BRANCH arcpatch-D20838 REVISION DETAIL

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. In D20838#457395 , @meven wrote: > I have fixed those two issues : > > - the path are now translated from kde url to mostlocal urls (dropping from desktop:/ works fine) (not from trash:/ though, but it currently does

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#456847 , @ngraham wrote: > In D20838#456831 , @meven wrote: > > > I have tested on my side, I don't understand why it does not work. > > From dolphin desktop:/ you

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57124. meven added a comment. Allow KDirModel to accept more actions when dropping on the model, simplify implementation, translates kde url to mostlocalurls when dropping REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57101. meven added a comment. Have to keep a reference to the connection in the object, or it gets deleted before the closure is run REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57099=57101 BRANCH

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57099. meven added a comment. Fix dropping directory REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57098=57099 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57098. meven added a comment. Use mostLocalUrls when resolving the dropped url, bettor organize code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57056=57098 BRANCH arcpatch-D20838 REVISION DETAIL

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. In D20838#456831 , @meven wrote: > I have tested on my side, I don't understand why it does not work. > From dolphin desktop:/ you can drag'n drop fine but not from the folder view. > I receive events and desktop:/

D20838: Allow to drop one file or one folder on KDirOperator

meven added a comment. In D20838#456820 , @ngraham wrote: > Wow, it works and it's so nice. What an improvement! :) > Drop options are not needed here; this isn't a move/copy/symlink UI; it's simply a quick way to choose a

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57056. meven added a comment. Remove unnecessary comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57027=57056 BRANCH arcpatch-D20838 REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

ngraham added a comment. Wow, it works and it's so nice. What an improvement! Drop options are not needed here; this isn't a move/copy/symlink UI; it's simply a quick way to choose a file that you happen to have visible in Dolphin or on the desktop. On that subject, I notice

D20838: Allow to drop one file or one folder on KDirOperator

meven added inline comments. INLINE COMMENTS > apol wrote in kdiroperator.cpp:418 > This default change should be documented. Not sure I have done this correctly. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel,

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57027. meven added a comment. Add a since in documentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57026=57027 BRANCH drop-kdiroperator REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven updated this revision to Diff 57026. meven added a comment. Review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20838?vs=57024=57026 BRANCH drop-kdiroperator REVISION DETAIL https://phabricator.kde.org/D20838 AFFECTED FILES

D20838: Allow to drop one file or one folder on KDirOperator

apol added inline comments. INLINE COMMENTS > kdiroperator.cpp:418 > setFocusPolicy(Qt::WheelFocus); > +setAcceptDrops(true); > } This default change should be documented. > kdiroperator.cpp:1401 > +} else { > +QUrl url = urls.at(0); > + .constFirst()

D20838: Allow to drop one file or one folder on KDirOperator

meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20838 To: meven, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20838: Allow to drop one file or one folder on KDirOperator

meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Open questions: - drop options Todo: - Add automated tests BUG: 45154 FIXED-IN: 5.58 TEST PLAN