This revision was automatically updated to reflect the committed changes.
Closed by commit R265:80cc612a50e9: Use locale currency for donate icon
(authored by broulik).
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21099?vs=57806&id=58540
REVISION DET
ngraham added a comment.
Filed an icon request bug for Breeze icons:
https://bugs.kde.org/show_bug.cgi?id=407372
In the meantime I think this is safe enough to land given that the fallback
mechanic will result in no visual changes until we actually get new icons.
REPOSITORY
R265 KConf
davidedmundson added inline comments.
INLINE COMMENTS
> kstandardaction.cpp:202
> +const QString currencyCode =
> QLocale().currencySymbol(QLocale::CurrencyIsoCode).toLower();
> +if (!currencyCode.isEmpty()) {
> +iconName =
> QStringLiteral("help-donate-%
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in kstandardaction.cpp:202
> else iconName = "help-donate" ?
That's the default specified in the struct already
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D21099
To: broulik, #frameworks,
sitter added a comment.
For obvious reasons I'd recommend only going for the major currencies :)
I've had a quick look at a part of our website visits and the following
currencies would be the most relevant based on that:
1. EUR
2. USD (this is actually the default icon so it's not
broulik added a comment.
https://en.wikipedia.org/wiki/ISO_4217#Active_codes if you want to have fun
with it I guess :D
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D21099
To: broulik, #frameworks, #vdg, ngraham
Cc: ngraham, sitter, kde-frameworks-devel, mi
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Is there a list of currency codes somewhere so that VDG can know what icons
we'll need to make to fully support this?
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricat
sitter added a comment.
LGTM
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D21099
To: broulik, #frameworks, #vdg
Cc: sitter, kde-frameworks-devel, michaelh, ngraham, bruns
broulik created this revision.
broulik added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
This allows the icon theme to provide a donate icon using the currency
symbol
