D21344: Port to ECMAddQmlModule

kossebau abandoned this revision. kossebau added a comment. Not sure of usefulness (see D20984#543937 ), so discarding myself. Happy to see someone else take over though if they feel this improves things. REPOSITORY R242 Plasma Framework

D21344: Port to ECMAddQmlModule

kossebau added a dependency: D20984: Add ECMAddQmlModule. REPOSITORY R242 Plasma Framework (Library) BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21344 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21344: Port to ECMAddQmlModule

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I like it :) REPOSITORY R242 Plasma Framework (Library) BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21344 To: kossebau, #plasma, apol Cc: apol,

D21344: Port to ECMAddQmlModule

kossebau updated this revision to Diff 59701. kossebau added a comment. update to latest ecm_add_qmlmodule draft REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21344?vs=58597=59701 BRANCH porttoECMInstallQmlModules REVISION DETAIL

D21344: Port to ECMAddQmlModule

kossebau updated this revision to Diff 58597. kossebau added a comment. udate to latest master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21344?vs=58492=58597 BRANCH porttoECMInstallQmlModules REVISION DETAIL

D21344: Port to ECMAddQmlModule

kossebau added a comment. The diff between the generated qmldir files and the manually written ones looks good. And also showed the one of plasmacore has some left-over. INLINE COMMENTS > CMakeLists.txt:37 > +OBJECT_TYPES > +BusyIndicator qml/BusyIndicator.qml > +Button

D21344: Port to ECMAddQmlModule

kossebau updated this revision to Diff 58492. kossebau added a comment. also remove include of ECMGenerateQmlTypes, newer macros cover that as well REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21344?vs=58491=58492 BRANCH

D21344: Port to ECMAddQmlModule

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY While the current logic for Plasma QML modules is stable and all repeated data