D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

apol added a comment. In D21369#480148 , @albertvaka wrote: > If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString? It is a string now, the advantage of u

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

albertvaka added a comment. If I understand correctly, the only reason to use KContacts here is so we can use its PhoneNumber type. We could change it to a QString? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: albertvaka, kde-framework

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a comment. In D21369#469389 , @apol wrote: > Seems like a clear layer break to spill KContacts over KPeople :P. > Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^' Sounds good REPOSITORY R307 KPeople RE

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

apol added a comment. Seems like a clear layer break to spill KContacts over KPeople :P. Let's discuss it at the sprint? INLINE COMMENTS > persondata.h:123 > + > +/** Returns an arbritrary phone number of the contact */ > +KContacts::PhoneNumber::List allPhoneNumbers() const; wrong

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman edited the summary of this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58565. sredman added a comment. - Hack on QMetaType support REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58561&id=58565 BRANCH kcontacts-phonenumber REVISION DETAIL https://phabricator.kde.org/D21369 A

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a dependent revision: D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58561. sredman added a comment. - Add link_library target to backends as well REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58556&id=58561 BRANCH kcontacts-phonenumber REVISION DETAIL https://phabricator

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58556. sredman added a comment. - Move KF5::Contacts to PUBLIC library REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58553&id=58556 BRANCH kcontacts-phonenumber REVISION DETAIL https://phabricator.kde.or

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sredman requested review of this revision. REVISION SUMMARY - Add phone number getters to PersonData - Add KContact::PhoneNumber properties to AbstractContact Does not cur