poboiko updated this revision to Diff 59951.
poboiko added a comment.
Rebase on master.
Since we now reindex folder always when cTime changes, revert `nameChanged()`
routine
Cover the case when we feed `UnIndexedFileIterator` with path that ends with
`/`
REPOSITORY
R293 Baloo
CHANG
poboiko added inline comments.
INLINE COMMENTS
> bruns wrote in unindexedfileiteratortest.cpp:100
> Make this plain members, not pointers.
> Also, one temporary dir is enough, you can put the db and the test tree
> side-by-side.
I wanted both DB and directory tree to be recreated from scratch f
poboiko updated this revision to Diff 59099.
poboiko marked 5 inline comments as done.
poboiko added a comment.
Use single temp dir
Fixed `mTime -> cTime`
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21509?vs=59071&id=59099
BRANCH
unindexed-renamed
bruns added inline comments.
INLINE COMMENTS
> unindexedfileiteratortest.cpp:100
> +Database* m_db;
> +QTemporaryDir* m_dbdir;
> +QTemporaryDir* m_testDir;
Make this plain members, not pointers.
Also, one temporary dir is enough, you can put the db and the test tree
side-by-side.
>
poboiko updated this revision to Diff 59071.
poboiko added a comment.
Fixed comment with directory structure
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21509?vs=59070&id=59071
BRANCH
unindexed-renamed
REVISION DETAIL
https://phabricator.kde.org/D215
poboiko added inline comments.
INLINE COMMENTS
> bruns wrote in unindexedfileiterator.cpp:126
> This whole block belongs into a separate block, executed `if
> (m_cTimeChanged)`.
Did you mean `m_mTimeChanged`?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21509
To: po
poboiko updated this revision to Diff 59070.
poboiko marked 3 inline comments as done.
poboiko added a comment.
Moved `m_nameChanged` check inside separate block
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21509?vs=59068&id=59070
BRANCH
unindexed-rename
poboiko updated this revision to Diff 59068.
poboiko added a comment.
Split test to three separate test functions, which cover different test cases.
Renamed folders to something more meaningful; put all the names as static
consts in the very beginning, for further reuse inside test func
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.
The unit test lacks structure, please think about:
- how you can split this into separate test cases (basic functionality,
renaming, ...)
- how to use a data driven approach f
poboiko created this revision.
poboiko added reviewers: Frameworks, Baloo, bruns.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
poboiko requested review of this revision.
REVISION SUMMARY
If some folder was renamed while `baloo_file` was not running,
10 matches
Mail list logo
