D21519: Rename ImageMake and ImageModel properties

This revision was automatically updated to reflect the committed changes. Closed by commit R286:131947acb0b2: Rename ImageMake and ImageModel properties (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21519?vs=59676=59816

D21519: Rename ImageMake and ImageModel properties

astippich updated this revision to Diff 59676. astippich added a comment. - rename to Manufacturer and Model REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21519?vs=58973=59676 BRANCH euqipment_properties REVISION DETAIL

D21519: Rename ImageMake and ImageModel properties

ngraham added a comment. All right, let's just go with "Manufacturer" and "Model" then. The values for these keys will probably make it clear enough. REPOSITORY R286 KFileMetaData BRANCH euqipment_properties REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham,

D21519: Rename ImageMake and ImageModel properties

astippich added a comment. In D21519#475829 , @bruns wrote: > In D21519#475821 , @ngraham wrote: > > > "Camera Manufacturer"? > > > Well, no ... also "Scanner, Phone, video digitizer, ..." >

D21519: Rename ImageMake and ImageModel properties

bruns added a comment. In D21519#475821 , @ngraham wrote: > "Camera Manufacturer"? Well, no ... also "Scanner, Phone, video digitizer, ..." Digikam just uses "Manufacturer" and "Model", as does Canons DPP REPOSITORY R286

D21519: Rename ImageMake and ImageModel properties

ngraham added a comment. "Camera Manufacturer"? REPOSITORY R286 KFileMetaData BRANCH euqipment_properties REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich,

D21519: Rename ImageMake and ImageModel properties

bruns added a comment. In D21519#475781 , @ngraham wrote: > In D21519#474885 , @astippich wrote: > > > @ngraham what's your take regarding "Manufacturer" vs. "Equipment Manufacturer"? > > >

D21519: Rename ImageMake and ImageModel properties

ngraham added a comment. In D21519#474885 , @astippich wrote: > @ngraham what's your take regarding "Manufacturer" vs. "Equipment Manufacturer"? "Manufacturer" is shorter, but since the metadata is attached to a photo, the longer

D21519: Rename ImageMake and ImageModel properties

astippich added a comment. @ngraham what's your take regarding "Manufacturer" vs. "Equipment Manufacturer"? REPOSITORY R286 KFileMetaData BRANCH euqipment_properties REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo,

D21519: Rename ImageMake and ImageModel properties

astippich added inline comments. INLINE COMMENTS > bruns wrote in propertyinfo.cpp:185 > Isn't `Manufacturer` sufficient for the label? Same for `Model`. Well, I wanted to make clear that it is all about the equipment used for recording, but if everyone agrees that it is sufficient without

D21519: Rename ImageMake and ImageModel properties

bruns added inline comments. INLINE COMMENTS > propertyinfo.cpp:185 > +d->name = QStringLiteral("equipmentManufacturer"); > +d->displayName = i18nc("@label EXIF", "Equipment Manufacturer"); > d->valueType = QVariant::String; Isn't `Manufacturer` sufficient

D21519: Rename ImageMake and ImageModel properties

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, much clearer REPOSITORY R286 KFileMetaData BRANCH euqipment_properties REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham, bruns Cc:

D21519: Rename ImageMake and ImageModel properties

astippich created this revision. astippich added reviewers: ngraham, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Provide a more generic and meaningful property and display

D21519: Rename ImageMake and ImageModel properties

astippich added a comment. If you have a better description for these, please let me know REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D21519 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich,