D21709: [PendingFileQueue] Avoid delete + create / create + delete race

2019-06-15 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:9b0ecc5d41b0: [PendingFileQueue] Avoid delete + create / create + delete race (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21709?vs=59473&id=59867#toc REPOSITORY R293

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

2019-06-14 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_races REVISION DETAIL https://phabricator.kde.org/D21709 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh,

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

2019-06-14 Thread Nathaniel Graham
ngraham added a comment. Awesome, thanks! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21709 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

2019-06-13 Thread Stefan Brüns
bruns added a comment. In D21709#477608 , @ngraham wrote: > LGTM, but maybe an autotest might make sense for this case. I have submitted some preliminary changes to make this more feasible. The current autotest structure is not really abl

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

2019-06-10 Thread Nathaniel Graham
ngraham added a comment. LGTM, but maybe an autotest might make sense for this case. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21709 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, s

D21709: [PendingFileQueue] Avoid delete + create / create + delete race

2019-06-09 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY When the 'delete' flag is set, the file was removed from th