nibags closed this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D21712
To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,
bruns, demsking, cullmann, sars, dhaumann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I would say: go for it.
And thanks for taking care!
REPOSITORY
R39 KTextEditor
BRANCH
move-qlistview
REVISION DETAIL
https://phabricator.kde.org/D21712
To: nibags,
ngraham added a comment.
+1, thanks!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D21712
To: nibags, #ktexteditor, cullmann, dhaumann
Cc: ngraham, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,
bruns, demsking, cullmann, sars, dhaumann
nibags updated this revision to Diff 59631.
nibags added a comment.
- Update tooltip of search bar
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21712?vs=59577=59631
BRANCH
move-qlistview
REVISION DETAIL
https://phabricator.kde.org/D21712
ngraham added inline comments.
INLINE COMMENTS
> katemodemenulist.cpp:85
> m_searchBar->setPlaceholderText(i18nc("Placeholder in search bar",
> "Search..."));
> +m_searchBar->setToolTip(i18nc("ToolTip of the search bar of modes of
> syntax highlighting", "Search for syntax
nibags updated this revision to Diff 59577.
nibags added a comment.
- Correct code style
Remove `this->` and `return` at the end of void functions.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21712?vs=59480=59577
BRANCH
move-qlistview
nibags edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D21712
To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham,
bruns, demsking, cullmann, sars, dhaumann
nibags created this revision.
nibags added reviewers: KTextEditor, cullmann, dhaumann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REVISION SUMMARY
The new Mode menu introduced in D20958
