This revision was automatically updated to reflect the committed changes.
Closed by commit R296:811e78ef0ee3: Calendar events: allow plugins to show
event details (authored by dvratil).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D21901?vs=60890=61798#toc
REPOSITORY
R296
apol added inline comments.
INLINE COMMENTS
> calendareventsplugin.h:236
> + *
> + * @since 5.60
> + */
should be since 5.61 now
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks, mart, apol
Cc: ngraham, broulik,
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks, mart, apol
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,
dvratil added a comment.
Ping?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks, mart
Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh,
bruns
dvratil updated this revision to Diff 60890.
dvratil added a comment.
Make the change truly API and ABI compatible
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21901?vs=60068=60890
BRANCH
master
REVISION DETAIL
ngraham added a comment.
Unrelatedly, if you don't already have KOrganizer installed, it would be
really nice if clicking on a day in the calendar showed a message that you need
to install KOrganizer to create events, with a button that installs it via
PackageKit when clicked on. That would
dvratil added a comment.
So, we are doomed to `CalendarEventsPluginV2`? *sadpanda*
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks, mart
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
broulik added a comment.
Adding a new `virtual` to a non-leaf class is never ABI compatible.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks, mart
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
dvratil added a reviewer: mart.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks, mart
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
dvratil added a dependent revision: D21906: Events plugin: implement the new
showEvent() API.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
dvratil updated this revision to Diff 60068.
dvratil added a comment.
- Fix ABI compatibility
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21901?vs=60065=60068
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21901
AFFECTED FILES
dvratil added a dependent revision: D21902: Calendar: add method to show event
details.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
dvratil added a reviewer: Frameworks.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D21901
To: dvratil, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
dvratil created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dvratil requested review of this revision.
REVISION SUMMARY
This adds new method to the plugin API that will allow plugins to show
event details when user clicks on the event,
14 matches
Mail list logo
