D22258: Improve plugin caching

wbauer added a comment. In D22258#539682 , @davidedmundson wrote: > I don't know the situation well enough to know whether it's valid that it's invalid or not. Let's follow that up in your bug report. The problem apparently is that the

D22258: Improve plugin caching

davidedmundson added a comment. I don't know the situation well enough to know whether it's valid that it's invalid or not. Let's follow that up in your bug report. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma,

D22258: Improve plugin caching

wbauer added inline comments. INLINE COMMENTS > davidedmundson wrote in pluginloader.cpp:860 > Changed. > Though that won't stop the warning from appearing. True. Maybe it would be better to downgrade it to qCDebug()? (until the existing invalid metadata is fixed at least) REPOSITORY R242

D22258: Improve plugin caching

davidedmundson added inline comments. INLINE COMMENTS > wbauer wrote in pluginloader.cpp:860 > Shouldn't this use categorized logging as well? > > It causes *lots* of warnings from plasmashell, see > https://bugs.kde.org/show_bug.cgi?id=412464 Changed. Though that won't stop the warning from

D22258: Improve plugin caching

wbauer added inline comments. INLINE COMMENTS > pluginloader.cpp:860 > +if (!metadata.isValid()) { > +qWarning() << "invalid metadata" << pluginPath; > +return; Shouldn't this use categorized logging as well? It causes *lots* of warnings from

D22258: Improve plugin caching

This revision was automatically updated to reflect the committed changes. Closed by commit R242:21227e0f989a: Improve plugin caching (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22258?vs=61122=61333 REVISION DETAIL

D22258: Improve plugin caching

apol updated this revision to Diff 61122. apol added a comment. addressed comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22258?vs=61113=61122 BRANCH caches REVISION DETAIL https://phabricator.kde.org/D22258 AFFECTED FILES

D22258: Improve plugin caching

mart accepted this revision. mart added a comment. move implementation out of definition and then ready to go REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma, davidedmundson, mart Cc: davidedmundson, mart,

D22258: Improve plugin caching

apol marked 3 inline comments as done. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma, davidedmundson Cc: davidedmundson, mart, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22258: Improve plugin caching

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Drop the qDebug I would suggest waiting till after the frameworks tag. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL

D22258: Improve plugin caching

mart added inline comments. INLINE COMMENTS > broulik wrote in pluginloader.cpp:120 > Remove or use categorized logging let's go with categorized REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22258 To: apol, #plasma Cc: mart, broulik,

D22258: Improve plugin caching

broulik added inline comments. INLINE COMMENTS > pluginloader.cpp:84 > +public: > +QVector findPluginsById(const QString& name, const > QStringList ) { > +const qint64 now = qRound64(QDateTime::currentMSecsSinceEpoch() > / 1000.0); Can you move the function

D22258: Improve plugin caching

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Extend the plasmoid startup cache to DataEngines and ContaimentActions. Include a cache for