D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R281:a3d262f58d2f: Allow updating default DBus timeout on every interface (authored by aleksanderm, committed by jgrulich). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE https://phabricator.

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Jan Grulich
jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R281 ModemManagerQt BRANCH aleksander/dbus-timeout REVISION DETAIL https://phabricator.kde.org/D22395 To: aleksanderm, #frameworks, jgrulich, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh,

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado
aleksanderm updated this revision to Diff 61582. aleksanderm added a comment. Renamed methods and made the getter const. REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22395?vs=61580&id=61582 BRANCH aleksander/dbus-timeout REVISION DETAIL https

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Jan Grulich
jgrulich added a comment. I think all the methods should be called timeout() and setTimeout(), you are not changing default timeout which will always be 25s if -1 is set as timeout value. Also the getters should be const methods. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://ph

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado
aleksanderm added a comment. F7006291: test.cpp attaching a tester program to exercise the new API in one of the interfaces. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D22395 To: aleksanderm, #frameworks, jgrulich, b

D22395: Allow updating default DBus timeout on every interface

2019-07-11 Thread Aleksander Morgado
aleksanderm created this revision. aleksanderm added reviewers: Frameworks, jgrulich, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added 1 blocking reviewer(s): jgrulich. aleksanderm requested review of this revision. REVISION SUMMARY Some