D22477: With auto completion don't show completions that don't match from beginning of typed word

mwolff added a comment. I agree, this is a feature, not a bug. If people are annoyed, they are usually annoyed by other issues like the one shown by Sven REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdev

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, kfunk Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, GB_2, domson, michaelh,

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir updated this revision to Diff 61881. ahmadsamir retitled this revision from "Add a config to only show completions matching word beginning" to "With auto completion don't show completions that don't match from beginning of typed word". ahmadsamir edited the summary of this revision. ah

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir updated this revision to Diff 61882. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Take 2 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22477?vs=61881&id=61882 BRANCH less-trigger-happy-completions (branched f

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir added a comment. In D22477#496214 , @brauch wrote: > I'm not sure if this solves the right problem. > > Where I notice this issue a lot is when typing "return". The keyword completion suggests "return", and when I want a newline, I

D22477: With auto completion don't show completions that don't match from beginning of typed word

brauch added inline comments. INLINE COMMENTS > katecompletionmodel.cpp:2029 > if (matchesAbbreviation(m_nameColumn, match, > model->matchCaseSensitivity())) { > matchCompletion = AbbreviationMatch; > } Maybe you want to set the flag here too? REPOSITORY R39 KT

D22477: With auto completion don't show completions that don't match from beginning of typed word

brauch added inline comments. INLINE COMMENTS > brauch wrote in katecompletionmodel.cpp:2029 > Maybe you want to set the flag here too? Actually no, probably not. ;) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaum

D22477: With auto completion don't show completions that don't match from beginning of typed word

brauch added a comment. Also here, looks good to me, but I would wait for feedback from somebody else in addition. Thank you for working on this! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, ko

D22477: With auto completion don't show completions that don't match from beginning of typed word

ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. Ping. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, kfunk Cc: brauch, kwrite-devel, kde-frameworks-deve

D22477: With auto completion don't show completions that don't match from beginning of typed word

cullmann added a comment. Any feedback on that from others? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22477 To: ahmadsamir, #ktexteditor, cullmann, dhaumann, #kdevelop, kossebau, mwolff, kfunk Cc: brauch, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,

D22477: With auto completion don't show completions that don't match from beginning of typed word

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Actually, I did read the bug once more and tried it out myself. I think we should not unconditionally remove that feature. If you read the bug, one user complaints about it,

D22477: With auto completion don't show completions that don't match from beginning of typed word

dhaumann added a comment. Unconditionally removing this is not a good idea, since the feature significantly helps to discover API via code completion. In any case, feedback from @kfunk, @molff is needed here imho REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org