D22586: KRun QML proxy: fix path/URL confusion

This revision was automatically updated to reflect the committed changes. Closed by commit R296:52b1133c3dcd: KRun QML proxy: fix path/URL confusion (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22586?vs=62138=62370#toc REPOSITORY R296 KDeclarative CHANGES

D22586: KRun QML proxy: fix path/URL confusion

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH D22586 REVISION DETAIL https://phabricator.kde.org/D22586 To: dfaure, davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22586: KRun QML proxy: fix path/URL confusion

dfaure added a comment. @davidedmundson @apol patch OK now? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22586 To: dfaure, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22586: KRun QML proxy: fix path/URL confusion

apol added a comment. In D22586#498715 , @dfaure wrote: > You'd think I would remember my own APIs :-) ;-) REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22586 To: dfaure, davidedmundson Cc: apol,

D22586: KRun QML proxy: fix path/URL confusion

dfaure updated this revision to Diff 62138. dfaure added a comment. You'd think I would remember my own APIs :-) REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22586?vs=62123=62138 BRANCH D22586 REVISION DETAIL

D22586: KRun QML proxy: fix path/URL confusion

apol added a comment. LGTM other than that. INLINE COMMENTS > krunproxy.cpp:35 > QMimeDatabase db; > -QMimeType mime = db.mimeTypeForFile(filePath); > -const QString fileMymeType = mime.name(); > +QMimeType mime = db.mimeTypeForFile(fileUrl.isLocalFile() ? >

D22586: KRun QML proxy: fix path/URL confusion

dfaure created this revision. dfaure added a reviewer: davidedmundson. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. dfaure requested review of this revision. REVISION SUMMARY I'm assuming the QString argument is always a