D22617: Add icons for pagelayout options, as needed in Okular

davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg, ndavis Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#500212 , @ndavis wrote: > In D22617#500031 , @davidhurka wrote: > > > I can’t follow you here. Centering the first page is a feature / technical detail of

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. In D22617#500168 , @davidhurka wrote: > Other icons with fold in the bottom I could find: > > - document-duplicate > - document-revert-symbolic[-rtl] > - kt-restore-defaults > - password-copy > - viewpdf > -

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. In D22617#500031 , @davidhurka wrote: > Makes sense, so I’m flipping snap-page now. Is that written down somewhere? Nope, it was recently decided, but I've had that in the back of my mind for a while. >

D22617: Add icons for pagelayout options, as needed in Okular

ngraham added a comment. In D22617#500141 , @davidhurka wrote: > In D22617#500131 , @ndavis wrote: > > > I'll give the latest changes a proper review in a little while. > > > > In D22617#500046

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#500131 , @ndavis wrote: > I'll give the latest changes a proper review in a little while. > > In D22617#500046 , @davidhurka wrote: > > > What is the

D22617: Add icons for pagelayout options, as needed in Okular

ndavis added a comment. I'll give the latest changes a proper review in a little while. In D22617#500046 , @davidhurka wrote: > What is the icons-dark directory good for? The icons in there are mostly just the same as in icons.

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. What is the icons-dark directory good for? The icons in there are mostly just the same as in icons. And I’m a bit concerned that scour-icon removes the id="currentColorScheme" attribute from the stylesheet. How do I avoid that? REPOSITORY R266 Breeze Icons

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka updated this revision to Diff 62294. davidhurka added a comment. - Rename pagelayout-* to view-pages-* REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22617?vs=62293=62294 BRANCH add-icons-for-pagelayouts REVISION DETAIL

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka updated this revision to Diff 62293. davidhurka added a comment. - Remove 24px icons - Flip snap-page icons vertically, so the corner fold is at the top-right - Make pagelayout-single link to snap-page - Flip pagelayout-* icons, except pagelayout-single REPOSITORY R266

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. In D22617#499767 , @ndavis wrote: > Nice work! > > I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom

D22617: Add icons for pagelayout options, as needed in Okular

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Nice work! I know a lot of monochrome icons currently use the bottom right position for the folded corner, but I think we should start using the top right. The bottom right

D22617: Add icons for pagelayout options, as needed in Okular

ngraham added a reviewer: ndavis. ngraham added a comment. The 16px version is used in menus. The 22px version is used in toolbar buttons. 24px is unnecessary; it's only used by some 3rd-party apps I think. The ones that are already in there at that size are legacy and maybe we should just

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a subscriber: Okular. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22617 To: davidhurka, #vdg Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka added a comment. I’m not sure whether I did everything correctly. If I did, this is too complicated. The guidelines in the community wiki and the HIG are missing:

D22617: Add icons for pagelayout options, as needed in Okular

davidhurka created this revision. davidhurka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidhurka requested review of this revision. REVISION SUMMARY This is my try to add the icons I requested in D21196#484674