D22689: Replace QString::null with QString

2019-07-24 Thread Albert Astals Cid
aacid abandoned this revision. aacid added a comment. Fixed it manually, marking it as abandoned since i can't close any other way. Sorry, should have tested this a bit more, yesterday it was late :/ REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid,

D22689: Replace QString::null with QString

2019-07-24 Thread Luigi Toscano
ltoscano added a comment. I can see that several frameworks can't build anymore on build.kde.org after the change. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol, nicolasfella Cc: ltoscano, nicolasfella, kde-frameworks-devel, LeGast00n, sbergero

D22689: Replace QString::null with QString

2019-07-23 Thread Nicolas Fella
nicolasfella reopened this revision. nicolasfella added a comment. This revision is now accepted and ready to land. This breaks building Okular for me [ 0%] Automatic MOC for target urldetecttest [ 0%] Automatic MOC for target okular [ 0%] Automatic MOC for target okularcore

D22689: Replace QString::null with QString

2019-07-23 Thread Nicolas Fella
nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol, nicolasfella Cc: nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22689: Replace QString::null with QString

2019-07-23 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22689: Replace QString::null with QString

2019-07-23 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22689: Replace QString::null with QString

2019-07-23 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D22689 AFFECTED FILES cmake/kf5i18nuic.cmake docs/