D22715: Save and load page margins

hoffmannrobert created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. hoffmannrobert requested review of this revision. REVISION SUMMARY Adapt and reapply former fix from https://cgit.kde.org/kate.git/commit/?id=1aa12bace6

D22715: Save and load page margins

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I think this is a good idea. Instead of KSharedConfig::openConfig() one should use KTextEditor::EditorPrivate::config() otherwise this is fine for me.

D22715: Save and load page margins

hoffmannrobert updated this revision to Diff 62475. hoffmannrobert added a comment. - Use KTextEditor::EditorPrivate::config() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22715?vs=62470&id=62475 BRANCH save_and_load_page_margins REVISION DETAIL

D22715: Save and load page margins

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R39 KTextEditor BRANCH save_and_load_page_margins REVISION DETAIL https://phabricator.kde.org/D22715 To: hoffmannrobert, cullmann Cc: cullmann, kwrite-devel,

D22715: Save and load page margins

This revision was automatically updated to reflect the committed changes. Closed by commit R39:2d02e5c684e3: Save and load page margins (authored by hoffmannrobert, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22715?vs=62475&id=624

D22715: Save and load page margins

dhaumann added a comment. Since the former patch was originally from me: I agree to accept it, but it has it's drawbacks: if you have multiple printers, having different margins is not possible, since this is not saved per printer. REPOSITORY R39 KTextEditor REVISION DETAIL https://phab

D22715: Save and load page margins

dhaumann added a comment. Btw, I recently wrote a mail to John Layt with the following content. The linked bug may be closed with this change: Hi John, quick question to the QPrinter: We still have issues in Kate (and other KDE apps I assume), that the margins of the QPrintDialog ar

D22715: Save and load page margins

cullmann added a comment. Should we add the printer name to the settings keys? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To: hoffmannrobert, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, univerz, LeGast00n, sbergeron, domson, mi

D22715: Save and load page margins

ltoscano added subscribers: aacid, ltoscano. ltoscano added a comment. I think @aacid recently (well, some time ago) worked on the Qt printing code and he may at least have an idea of the status of this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To: h

D22715: Save and load page margins

aacid added a comment. > It seems the QPrinter/QPrintDialog still do not correctly read info from CUPS E_NEEDS_MORE_INFO > neither does it correctly remember print settings This is by design AFAIK, but maybe a patch would be accepted if people would submit one. I'm still not co

D22715: Save and load page margins

dhaumann added a comment. I think adding the printer name makes sense. We could go the full road, see: https://stackoverflow.com/a/14979437/2224190 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To: hoffmannrobert, cullmann Cc: ltoscano, aacid, dhaumann, c