This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:6709de184aa3: Add ECMAddQtDesignerPlugin (authored by
kossebau).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE
kossebau added a comment.
Seems people so far are fine with this, any comments were rather positive. No
changes requested.
So unless someone objects, would then proceed to push soon after KF 5.61 has
been branched upcoming WE. Scheduling myself for Tuesday, August 6th currently,
so
apol added a comment.
+1 LGTM
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22724
To: kossebau, #build_system, #frameworks
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron,
bencreasy, michaelh, ngraham, bruns
kossebau retitled this revision from "[WIP] Add ECMAddQtDesignerPlugin" to "Add
ECMAddQtDesignerPlugin".
kossebau edited the summary of this revision.
kossebau added reviewers: Build System, Frameworks.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22724