D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau created this revision. kossebau added reviewers: ochurlaud, bshah. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Handling projects where metainfo.yaml are th

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. Or maybe just drop support for Python 2 entirely? - kapidox is rarely used - Python 2 will be EOL in 5 months - distros either switched kapidox to Python 3, or will do it soon REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D22836 To: ko

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504352 , @pino wrote: > Or maybe just drop support for Python 2 entirely? > > - kapidox is rarely used > - Python 2 will be EOL in 5 months > - distros either switched kapidox to Python 3, or will do it

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504355 , @kossebau wrote: > Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test that, At this point, making Python stuff work with Python3 is priority one.

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504356 , @pino wrote: > In D22836#504355 , @kossebau wrote: > > > Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time t

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504357 , @kossebau wrote: > In D22836#504356 , @pino wrote: > > > In D22836#504355 , @kossebau wrote: > > > > > Just in

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504358 , @pino wrote: > Oh dear, and what about switching the api generation to Python 3 instead? Nobody is stopped to work on that. I am not a Python expert, I just providing here the small fix which f

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504359 , @kossebau wrote: > In D22836#504358 , @pino wrote: > > > Oh dear, and what about switching the api generation to Python 3 instead? > > > Nobody is stoppe

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. Let me add one more thing: I understand you care about API docs, about making them available for our users on api.kde.org, and about giving the best impression possible about them (I remember various patches about that in the past). I just don't agree with the "how

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Pino please take a step back and rethink your position. Yes, supporting Python2 sucks, but this is **2** lines of code while porting everything to Python 3 is lots of work more. If

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504389 , @aacid wrote: > Pino please take a step back and rethink your position. > Yes, supporting Python2 sucks, but this is **2** lines of code while porting everything to Python 3 is lots of work more.

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

aacid added a comment. Ok, yep i may have misunderstood :) But if you say "kapidox supports Python 2.7" we need to commit this to keep it true :) REPOSITORY R264 KApiDox BRANCH handlenonasciipathwpython27 REVISION DETAIL https://phabricator.kde.org/D22836 To: kossebau, ochurlaud

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504393 , @aacid wrote: > Ok, yep i may have misunderstood :) > > But if you say "kapidox supports Python 2.7" we need to commit this to keep it true :) See my very first comment. REPOSITORY R264 KApi

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

davidre added a comment. @kossebau also wrote In D22836#504355 , @kossebau wrote: > That as well, as also discussed on irc today. > > Just in case that other scripts on api.kde.org do not work yet with Python3 or no-one has time to test

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

pino added a comment. In D22836#504394 , @davidre wrote: > In D22836#504355 , @kossebau wrote: > > > That as well, as also discussed on irc today. > > > > Just in case that other scripts on api.k

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. I find myself in line with what @aacid said ;) The whole idea of this patch is to plug in api.kde.org back instantly, so everyone working e.g. on apps for which special new API was added to some KDE Frameworks module can see their API dox. Switching the whole

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

kossebau added a comment. In D22836#504361 , @pino wrote: > Let me add one more thing: I understand you care about API docs, about making them available for our users on api.kde.org, For the record, actually I care more for having docs av

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

bshah accepted this revision. bshah added a comment. As a short term workaround, this is fine, in terms of porting to python3 it will also need changes on our server zivo.kde.org which is hosting api.kde.org, right now every scripts including krazy2 and apidox generation scripts are too much

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

lbeltrame accepted this revision. lbeltrame added a comment. Not the prettiest, but I've seen worse. ;) REPOSITORY R264 KApiDox BRANCH handlenonasciipathwpython27 REVISION DETAIL https://phabricator.kde.org/D22836 To: kossebau, ochurlaud, bshah, aacid, lbeltrame Cc: lbeltrame, davidre

D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

This revision was automatically updated to reflect the committed changes. Closed by commit R264:1c08ce74d29f: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7 (authored by kossebau). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22836?