This revision was automatically updated to reflect the committed changes.
Closed by commit R245:f7149af10e4b: Only build tests when DBus is available
(authored by nicolasfella).
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23149?vs=63732&id=64104
REVISION DET
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R245 Solid
BRANCH
dbustest
REVISION DETAIL
https://phabricator.kde.org/D23149
To: nicolasfella, bcooksley, broulik, bruns, #frameworks, apol
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, G
nicolasfella updated this revision to Diff 63732.
nicolasfella added a comment.
- Fix case
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23149?vs=63712&id=63732
BRANCH
dbustest
REVISION DETAIL
https://phabricator.kde.org/D23149
AFFECTED FILES
CMakeL
nicolasfella marked an inline comment as done.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D23149
To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngraham,
bruns
nicolasfella added a comment.
Yes, QtDBus is available on Windows, so no change there
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D23149
To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: aspotashev, vkrause, kde-frameworks-devel, LeGast00n, michaelh, ngra
aspotashev added a comment.
At least for now Window CI tries and tests something:
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.13/1/console
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D23149
To: nicolasfella, bcooksley, broulik,
aspotashev added a comment.
Does this mean we cannot test Solid on Windows CI?
https://api.kde.org/frameworks/solid/html/ says Solid is supported also on
Windows.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D23149
To: nicolasfella, bcooksley, broulik, bruns, #fram
vkrause added inline comments.
INLINE COMMENTS
> CMakeLists.txt:127
> add_subdirectory(src)
> -if (BUILD_TESTING)
> +if (TARGET QT5::DBus AND BUILD_TESTING)
> add_subdirectory(autotests)
Qt5::DBus, not sure if this is case-sensitive, if it is this would disable the
tests for everyone I th
nicolasfella added reviewers: bcooksley, broulik, bruns, Frameworks.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D23149
To: nicolasfella, bcooksley, broulik, bruns, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
The tests require DBus
REPOSITORY
R245 Solid
BRANCH
dbustest
REVISION DETAIL
https://phabricator.kde.
10 matches
Mail list logo