D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in query.h:101 > "5.62" of course :) Thanks D23555 REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To:

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in query.h:101 > Please add "@since 6.62" to all this new API, so consumers of them know which > min version of KActivitiesStat they need to require to be able to rely on > their existance. "5.62" of course :) REPOSITORY R159

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

kossebau added inline comments. INLINE COMMENTS > query.h:101 > void addUrlFilters(const QStringList ); > +void setTypes(const Terms::Type ); > +void setAgents(const Terms::Agent ); Please add "@since 6.62" to all this new API, so consumers of them know which min version of

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ivan wrote in query.h:105 > I screwed up the names - plurals vs singulars here as `Agent` can contain > several agents - having `Agent::current` looked better than `Agents::current`. > > We'll need to do

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

This revision was automatically updated to reflect the committed changes. Closed by commit R159:e67c20ab0f69: Add setter to Type, Activity, Agent and UrlFilter query fields (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399 To: meven, ivan Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven updated this revision to Diff 64501. meven added a comment. Only have set*(Term), add setter for date REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23399?vs=64475=64501 BRANCH master REVISION DETAIL

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

ivan added inline comments. INLINE COMMENTS > query.h:105 > +void setUrlFilters(const QStringList ); > +void setType(const Terms::Type ); > +void setAgent(const Terms::Agent ); I screwed up the names - plurals vs singulars here as `Agent` can contain several agents - having

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven updated this revision to Diff 64475. meven added a comment. Add QStringList setters REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23399?vs=64474=64475 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399 AFFECTED

D23399: Add setter to Type, Activity, Agent and UrlFilter query fields

meven created this revision. meven added a reviewer: ivan. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D23399