D23516: Fix for all themes: allow turn off attributes in XML highlighting files

This revision was automatically updated to reflect the committed changes. Closed by commit R39:00721e80b5b4: Fix for all themes: allow turn off attributes in XML highlighting files (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phab

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

dhaumann accepted this revision. REPOSITORY R39 KTextEditor BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 To: nibags, #ktexteditor, cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cu

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think this is fine, as soon as the other patch is in, feel free to commit! REPOSITORY R39 KTextEditor BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 To

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

nibags updated this revision to Diff 65018. nibags added a comment. - Update function names REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23516?vs=64780&id=65018 BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 AFFECTED FILE

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

dhaumann added a comment. I like it, although this all will not be needed anymore oncee KTextEditor is fully ported to KSyntaxHighlighting::Theme. Still a long way to go. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23516 To: nibags, #ktexteditor, cull

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

nibags created this revision. nibags added reviewers: KTextEditor, cullmann, vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Depends on D23515