D23550: CMake config files: use as min dep version the Qt version we built against

kossebau abandoned this revision. kossebau added a comment. Oh well, seems no-one else sees the light yet ;) Given this IMHO wrong data in the current CMake config files does not do actual harm in 99.9 % cases I will discard this for now, and just do it correctly (for what I see) only in my

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. Just, the built binary no longer has that theoretical minimum dependency, it needs at least the Qt version the very instance of kcoreaddons was built against. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau,

D23550: CMake config files: use as min dep version the Qt version we built against

cgiboudeaux added a comment. In D23550#569554 , @kossebau wrote: > In D23550#569552 , @cgiboudeaux wrote: > > > In D23550#569485 , @kossebau wrote: > >

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. In D23550#569552 , @cgiboudeaux wrote: > In D23550#569485 , @kossebau wrote: > > > ping :) No-one any opinion? > > > Sure :) > -1. The Config file is supposed to

D23550: CMake config files: use as min dep version the Qt version we built against

cgiboudeaux added a comment. In D23550#569485 , @kossebau wrote: > ping :) No-one any opinion? Sure :) -1. The Config file is supposed to look for the lowest supported version. REPOSITORY R244 KCoreAddons REVISION DETAIL

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. ping :) No-one any opinion? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau, #frameworks, #build_system Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a reviewer: Build System. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau, #frameworks, #build_system Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. If you think this makes sense, I would do the same change to all KDE Frameworks modules (and hope others pick up for their code with public library API). Target: KF 5.63 earliest. REPOSITORY R244 KCoreAddons REVISION DETAIL

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Some developers have multiple versions of Qt installed on their system. And