sitter retitled this revision from "WIP: port ftp slave to new error reporting
system" to "port ftp slave to new error reporting system".
sitter edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23579
To: sitter, dfaure
Cc: anthonyfieroni,
sitter updated this revision to Diff 67697.
sitter added a comment.
move away from helper functions to redirect to q-> and instaed call via q->
directly
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23579?vs=67695&id=67697
BRANCH
ftp
REVISION DETAIL
htt
sitter edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23579
To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ngraham, bruns
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Excellent work!
INLINE COMMENTS
> ftp.cpp:2635
> +
> +#pragma message "was this useful? I have no clue where or how keepalive
> would work with ftp"
> +//authenticator->set
This revision was automatically updated to reflect the committed changes.
sitter marked 3 inline comments as done.
Closed by commit R241:c86eedf0f92d: port ftp slave to new error reporting
system (authored by sitter).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D23579?vs=67697&id=67883#
dfaure added a comment.
@sitter The unittest just failed on CI, the test can't connect to the local
FTP server, can you look into it?
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/211/testReport/junit/projectroot/autotests/kiocore_ftptest/
REPOSITORY
R241 KIO
sitter added a comment.
I'll see about adding some debug output for the daemon state. Hard to say why
it's flakey with the info at hand.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23579
To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n,
dfaure added a comment.
Wait, nevermind, it was a regression in the mapConfig() related code, fixed
meanwhile. KIO is green again on CI. Sorry for the false alert.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23579
To: sitter, dfaure
Cc: anthonyfieroni, dfaure, kde-f