D23645: Do not generate string list at runtime

dhaumann added a subscriber: mwolff. dhaumann added inline comments. INLINE COMMENTS > kossebau wrote in katemodemanager.cpp:214 > I saw you mentioned this elsewhere, but thought it was a typo. Never seen > this before, so curious to leatn what advantage using an initializer list > brings

D23645: Do not generate string list at runtime

kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in katemodemanager.cpp:214 > I would even prefer: > > static const auto commonSuffixes = { ... }; > > This way it's an initializer_list and a pattern we use at other places in > KTextEditor as well. But of course, your patch

D23645: Do not generate string list at runtime

dhaumann added inline comments. INLINE COMMENTS > katemodemanager.cpp:214 > if (! fileName.isEmpty()) { > -static const QStringList commonSuffixes = > QStringLiteral(".orig;.new;~;.bak;.BAK").split(QLatin1Char(';')); > +static const QLatin1String commonSuffixes[] = { > +

D23645: Do not generate string list at runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R39:a7212d561de1: Do not generate string list at runtime (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23645?vs=65164=65170 REVISION DETAIL

D23645: Do not generate string list at runtime

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is nicer, yes! REPOSITORY R39 KTextEditor BRANCH preparelistatbuildtie REVISION DETAIL https://phabricator.kde.org/D23645 To: kossebau, #kate, cullmann Cc:

D23645: Do not generate string list at runtime

kossebau updated this revision to Diff 65164. kossebau added a comment. now as plain array REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23645?vs=65124=65164 BRANCH preparelistatbuildtie REVISION DETAIL https://phabricator.kde.org/D23645

D23645: Do not generate string list at runtime

kossebau added a comment. (And thanks for all the quick review :) ) In D23645#523622 , @cullmann wrote: > Hmm, could we here now avoid the QStringList completely and just use a normal array with a range based for below? Okay, looks

D23645: Do not generate string list at runtime

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Hmm, could we here now avoid the QStringList completely and just use a normal array with a range based for below? REPOSITORY R39 KTextEditor REVISION DETAIL

D23645: Do not generate string list at runtime

kossebau created this revision. kossebau added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY GIT_SILENT REPOSITORY R39 KTextEditor BRANCH